kern/50904: Fix variable assignment inside if-clause.

[henning.petersen%t-online.de@localhost]

>Number:         50904
>Category:       kern
>Synopsis:       Fix variable assignment inside if-clause.
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Mar 07 10:20:00 +0000 2016
>Originator:     Henning Petersen
>Release:        -current
>Organization:
>Environment:
>Description:
Fix variable assignment inside if-clause.
>How-To-Repeat:

>Fix:
diff -u -p -r1.25 if_smsc.c
--- sys/dev/usb/if_smsc.c	9 Feb 2016 08:32:12 -0000	1.25
+++ sys/dev/usb/if_smsc.c	7 Mar 2016 09:46:15 -0000
@@ -772,7 +772,7 @@ smsc_chip_init(struct smsc_softc *sc)
 	smsc_write_reg(sc, SMSC_PM_CTRL, SMSC_PM_CTRL_PHY_RST);
 
 	if ((err = smsc_wait_for_bits(sc, SMSC_PM_CTRL,
-	    SMSC_PM_CTRL_PHY_RST) != 0)) {
+	    SMSC_PM_CTRL_PHY_RST)) != 0) {
 		smsc_warn_printf(sc, "timed-out waiting for phy reset to "
 		    "complete\n");
 		goto init_failed;