kern/50927: src/sys/dev/ic/arn9003.c:2238]: (style) Suspicious condition

[dcb314%hotmail.com@localhost]

>Number:         50927
>Category:       kern
>Synopsis:       src/sys/dev/ic/arn9003.c:2238]: (style) Suspicious condition
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Mar 09 12:40:00 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160308
>Organization:
>Environment:
>Description:

src/sys/dev/ic/arn9003.c:2238]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

   if ((iq_corr_neg = cal->iq_corr_meas < 0))

That could be tidier.

Also in the same source code file is

[src/sys/dev/ic/arn9003.c:2872]: (style) Variable 'scale' is assigned a value that is never used.

Suggest either use it or delete it.


>How-To-Repeat:

>Fix: