kern/50948: src/sys/dev/ic/malo.c:1626]: (style) Suspicious condition

[dcb314%hotmail.com@localhost]

>Number:         50948
>Category:       kern
>Synopsis:       src/sys/dev/ic/malo.c:1626]: (style) Suspicious condition
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Mar 11 17:20:00 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160311
>Organization:
>Environment:
>Description:
src/sys/dev/ic/malo.c:1626]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.


Source code is

  if ((error = firmware_open("malo", name, &fw) != 0)) {



Maybe better code

  if ((error = firmware_open("malo", name, &fw)) != 0) {


   

  



>How-To-Repeat:

>Fix: