Re: kern/50949: src/sys/dev/pcmcia/if_malo_pcmcia.c:637]: (style) Suspicious condition

[David Holland <dholland-bugs%netbsd.org@localhost>]

The following reply was made to PR kern/50949; it has been noted by GNATS.

From: David Holland <dholland-bugs%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/50949: src/sys/dev/pcmcia/if_malo_pcmcia.c:637]: (style)
 Suspicious condition
Date: Sat, 12 Mar 2016 01:42:53 +0000

 On Fri, Mar 11, 2016 at 05:25:26PM +0000, Paul_Koning%Dell.com@localhost wrote:
  > It's a matter of preference, I'll admit.  But I would much rather
  > see such constructs written as two statements:
  > 
  > error = ieee80211_media_change(ifp);
  > if (error != ENETRESET) ....
 
 Me too, for what it's worth. Vertical space doesn't seem as valuable
 in the days of 80-line editor windows as it once did.
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost