NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: kern/50629: netbsd-7 kernel panic



On Mar 14, 12:05pm, 6bone%6bone.informatik.uni-leipzig.de@localhost (6bone%6bone.informatik.uni-leipzig.de@localhost) wrote:
-- Subject: re: kern/50629: netbsd-7 kernel panic

Unfortunately the fix is not easy. I believe that the ipf mutex is held
so that there can be no rule changes during packet processing. Alas, we
can't obtain an rwlock in an interrupt context so let's just disable that
for now...

christos

Index: fil.c
===================================================================
RCS file: /cvsroot/src/sys/external/bsd/ipf/netinet/fil.c,v
retrieving revision 1.16
diff -u -u -r1.16 fil.c
--- fil.c	2 Apr 2015 00:12:58 -0000	1.16
+++ fil.c	14 Mar 2016 16:42:42 -0000
@@ -2916,7 +2916,9 @@
 		LBUMPD(ipf_stats[out], fr_short);
 	}
 
+#if 0
 	READ_ENTER(&softc->ipf_mutex);
+#endif
 
 	if (!out) {
 		switch (fin->fin_v)
@@ -3048,9 +3050,10 @@
 		fr->fr_ref++;
 		MUTEX_EXIT(&fr->fr_lock);
 	}
-
+#if 0
 	RWLOCK_EXIT(&softc->ipf_mutex);
 #endif
+#endif
 
 	if ((pass & FR_RETMASK) != 0) {
 		/*
@@ -3146,8 +3149,10 @@
 #endif
 	}
 #if !defined(FASTROUTE_RECURSION)
+#if 0
 	RWLOCK_EXIT(&softc->ipf_mutex);
 #endif
+#endif
 
 finished:
 	if (!FR_ISPASS(pass)) {


Home | Main Index | Thread Index | Old Index