Re: pkg/50767

[Tobias Nygren <tnn%NetBSD.org@localhost>]

The following reply was made to PR toolchain/50767; it has been noted by GNATS.

From: Tobias Nygren <tnn%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/50767
Date: Sat, 18 Jun 2016 14:54:34 +0200

 The problem is back again with firefox 47 on head-LLVM amd64.
 This patch makes it work. I'm not sure if there is a better way.
 (it was suggested on IRC that it maybe should use visibility hidden.)
 
 --- ../firefox.orig/patches/patch-toolkit_library_libxul.mk	1970-01-01 01:00:00.000000000 +0100
 +++ ./patches/patch-toolkit_library_libxul.mk	2016-06-18 14:37:23.125665064 +0200
 @@ -0,0 +1,16 @@
 +$NetBSD$
 +
 +Can't do relocation against extern protected symbol.
 +pkg/50767
 +
 +--- toolkit/library/libxul.mk.orig	2016-06-18 12:32:59.901404958 +0000
 ++++ toolkit/library/libxul.mk
 +@@ -55,7 +55,7 @@ endif
 + ifdef _MSC_VER
 + get_first_and_last = dumpbin -exports $1 | grep _NSModule@@ | sort -k 3 | sed -n 's/^.*?\([^@]*\)@@.*$$/\1/;1p;$$p'
 + else
 +-get_first_and_last = $(TOOLCHAIN_PREFIX)nm -g $1 | grep _NSModule$$ | grep -vw refptr | sort | sed -n 's/^.* _*\([^ ]*\)$$/\1/;1p;$$p'
 ++get_first_and_last = $(TOOLCHAIN_PREFIX)nm $1 | grep _NSModule$$ | grep -vw refptr | sort | sed -n 's/^.* _*\([^ ]*\)$$/\1/;1p;$$p'
 + endif
 + 
 + LOCAL_CHECKS = test "$$($(get_first_and_last) | xargs echo)" != "start_kPStaticModules_NSModule end_kPStaticModules_NSModule" && echo "NSModules are not ordered appropriately" && exit 1 || exit 0
 diff -bruN -x CVS ../firefox.orig/patches/patch-xpcom_components_Module.h ./patches/patch-xpcom_components_Module.h
 --- ../firefox.orig/patches/patch-xpcom_components_Module.h	1970-01-01 01:00:00.000000000 +0100
 +++ ./patches/patch-xpcom_components_Module.h	2016-06-18 14:37:26.581726776 +0200
 @@ -0,0 +1,16 @@
 +$NetBSD$
 +
 +Can't do relocation against extern protected symbol.
 +pkg/50767
 +
 +--- xpcom/components/Module.h.orig	2016-06-01 04:11:44.000000000 +0000
 ++++ xpcom/components/Module.h
 +@@ -125,7 +125,7 @@ struct Module
 + #    define NSMODULE_SECTION __declspec(allocate(".kPStaticModules$M"), dllexport)
 + #  elif defined(__GNUC__)
 + #    if defined(__ELF__)
 +-#      define NSMODULE_SECTION __attribute__((section(".kPStaticModules"), visibility("protected")))
 ++#      define NSMODULE_SECTION __attribute__((section(".kPStaticModules"), visibility("visible")))
 + #    elif defined(__MACH__)
 + #      define NSMODULE_SECTION __attribute__((section("__DATA, .kPStaticModules"), visibility("default")))
 + #    elif defined (_WIN32)