bin/51298: src/usr.bin/error/pi.c: 2 * redundant condition ?

[dcb314%hotmail.com@localhost]

>Number:         51298
>Category:       bin
>Synopsis:       src/usr.bin/error/pi.c: 2 * redundant condition ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jun 30 08:50:00 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160630
>Organization:
>Environment:
>Description:
src/usr.bin/error/pi.c:221]: (style) Redundant condition: If 'EXPR == '-'', the comparison 'EXPR' is always true.
src/usr.bin/error/pi.c:226]: (style) Redundant condition: If 'EXPR == '-'', the comparison 'EXPR' is always true.

Source code is

    while (*string && *string == '-')

and

    while (*string && *string == '-')


>How-To-Repeat:

>Fix: