NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: bin/51264: Fix src/sbin/fsck_lfs/bufcache.c



I have seen that it is called by the cleaner daemon, but I don't know
in which cases the cleaner daemon do a rehash (I haven't read any of
the cleaner code yet).

Do as you think it is better

On Sun, Jul 31, 2016 at 8:45 PM, David Holland <dholland-bugs%netbsd.org@localhost> wrote:
> The following reply was made to PR bin/51264; it has been noted by GNATS.
>
> From: David Holland <dholland-bugs%netbsd.org@localhost>
> To: gnats-bugs%NetBSD.org@localhost
> Cc:
> Subject: Re: bin/51264: Fix src/sbin/fsck_lfs/bufcache.c
> Date: Sun, 31 Jul 2016 18:43:59 +0000
>
>  On Wed, Jun 22, 2016 at 06:15:00PM +0000, joseyluis%gmail.com@localhost wrote:
>   > I think that this fix must be pulled to NetBSD 7 and NetBSD 6
>   > (mainly case 1), because it can affect to the cleaner daemon and
>   > fsck_lfs.
>
>  The impact is limited (I think zero actually) because none of the
>  tools resize more than once and they do it during initialization
>  before there are buffers to rehash. Do you have a case in mind where
>  it breaks?
>
>  I'm not opposed to pulling it up, I'm just not sure it's actually
>  necessary.
>
>  --
>  David A. Holland
>  dholland%netbsd.org@localhost
>


Home | Main Index | Thread Index | Old Index