Re: PR/51840 CVS commit: src/tests/lib/libc/sys

["Ngie Cooper (yaneurabeya)" <yaneurabeya%gmail.com@localhost>]

On Jan 13, 2017, at 11:30 AM, Christos Zoulas <christos%netbsd.org@localhost> wrote:

The following reply was made to PR bin/51840; it has been noted by GNATS.

From: "Christos Zoulas" <christos%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc:
Subject: PR/51840 CVS commit: src/tests/lib/libc/sys
Date: Fri, 13 Jan 2017 14:27:23 -0500

Module Name: src
Committed By: christos
Date: Fri Jan 13 19:27:23 UTC 2017

Modified Files:
src/tests/lib/libc/sys: t_write.c

Log Message:
PR/51840: Ngie Cooper: portability fixes for FreeBSD, etc


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/tests/lib/libc/sys/t_write.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Is there a reason why the limits.h #include wasn’t added as well? It’s needed for SIZE_MAX on FreeBSD (at least).

Thanks,

-Ngie

$ cvs diff -u lib/libc/sys/t_write.c 

Index: lib/libc/sys/t_write.c

===================================================================

RCS file: /cvsroot/src/tests/lib/libc/sys/t_write.c,v

retrieving revision 1.3

diff -u -r1.3 t_write.c

--- lib/libc/sys/t_write.c      13 Jan 2017 19:27:23 -0000      1.3

+++ lib/libc/sys/t_write.c      13 Jan 2017 23:13:48 -0000

@@ -36,6 +36,7 @@

 #include <atf-c.h>

 #include <errno.h>

 #include <fcntl.h>

+#include <limits.h>

 #include <signal.h>

 #include <limits.h>

 #include <stdio.h>