NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: kern/51528



On 01/30/17 20:55, smesgr wrote:
The following reply was made to PR kern/51528; it has been noted by GNATS.

From: smesgr <smesgr%gmail.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc:
Subject: Re: kern/51528
Date: Mon, 30 Jan 2017 21:54:29 +0100

  this patch works for me:
Index: sys/dev/usb/ohci.c
  ===================================================================
  RCS file: /cvsroot/src/sys/dev/usb/ohci.c,v
  retrieving revision 1.265
  diff -u -r1.265 ohci.c
  --- sys/dev/usb/ohci.c    4 Dec 2016 10:12:35 -0000    1.265
  +++ sys/dev/usb/ohci.c    30 Jan 2017 20:53:03 -0000
  @@ -632,7 +632,7 @@
             * crossing per TD
             */
            curlen = len;
  -        if (!(sphyspg == ephyspg || sphyspg + 1 == ephyspg)) {
  +        if (!(sphyspg == ephyspg || sphyspg + OHCI_PAGE_SIZE == ephyspg)) {
                /* must use multiple TDs, fill as much as possible. */
                curlen = 2 * OHCI_PAGE_SIZE -
                    (sdataphys & (OHCI_PAGE_SIZE - 1));

Thanks... I'd spotted the bug as well.  I've committed your change as
sys/dev/usb/ohci.c:1.266 and updated the file with some other fixes / improvement.

Please re-test to make sure it still works :)

Nick


Home | Main Index | Thread Index | Old Index