bin/52189: Building with MKCRYPTO=no is broken

[paul%whooppee.com@localhost]

>Number:         52189
>Category:       bin
>Synopsis:       Building with MKCRYPTO=no is broken
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Apr 22 23:30:00 +0000 2017
>Originator:     Paul Goyette
>Release:        NetBSD 7.99.66
>Organization:
+------------------+--------------------------+----------------------------+
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:          |
| (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com   |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org |
+------------------+--------------------------+----------------------------+
>Environment:
	
	
System: NetBSD speedy.whooppee.com 7.99.66 NetBSD 7.99.66 (SPEEDY 2017-03-24 21:50:36 UTC) #0: Fri Mar 24 22:50:09 UTC 2017 paul%speedy.whooppee.com@localhost:/build/netbsd-local/obj/amd64/sys/arch/amd64/compile/SPEEDY amd64
Architecture: x86_64
Machine: amd64
>Description:
Building with MKCRYPTO=no is broken.  With a 'build.sh ... -j 1 release'
we get

#   compile  ntpd/ntp_control.o
/build/netbsd-local/tools/x86_64/amd64/bin/x86_64--netbsd-gcc -O2 -fPIE    -std=gnu99    -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wno-sign-compare  -Wsystem-headers   -Wno-traditional   -Wa,--fatal-warnings  -Wreturn-type -Wswitch -Wshadow -Wcast-qual -Wwrite-strings -Wextra -Wno-unused-parameter -Wno-sign-compare -Wsign-compare -Wformat=2  -Wno-format-zero-length  -Werror -Wno-missing-noreturn    --sysroot=/build/netbsd-local/dest/amd64 -DHAVE_CONFIG_H -I/build/netbsd-local/src_ro/external/bsd/ntp/include  -I/build/netbsd-local/src_ro/external/bsd/ntp/dist/include  -I/build/netbsd-local/src_ro/external/bsd/ntp/dist/lib/isc/include  -I/build/netbsd-local/src_ro/external/bsd/ntp/dist/lib/isc/unix/include  -I/build/netbsd-local/src_ro/external/bsd/ntp/dist/lib/isc/nothreads/include -DHAVE_DNSREGISTRATION=1 -DWANT_IPV6 -I/build/netbsd-local/src_ro/external/bsd/ntp/dist/include -I/build/netbsd-local/src_ro/external/bsd/ntp/dist/sntp/libopts -I/build/netbsd-
 local/sr
 c_ro/external/bsd/ntp/dist/ntpd -I.  -c  -Wno-format-nonliteral  -Wno-error=maybe-uninitialized   /build/netbsd-local/src_ro/external/bsd/ntp/dist/ntpd/ntp_control.c
In file included from /build/netbsd-local/src_ro/external/bsd/ntp/dist/ntpd/ntp_control.c:31:0:
/build/netbsd-local/src_ro/external/bsd/ntp/dist/ntpd/ntp_control.c: In function 'derive_nonce':
/build/netbsd-local/src_ro/external/bsd/ntp/dist/include/ntp_md5.h:36:44: error: right-hand operand of comma expression has no effect [-Werror=unused-value]
 # define EVP_DigestInit(c, dt)  (MD5Init(c), (dt ? 1 : 1))
                                            ^
/build/netbsd-local/src_ro/external/bsd/ntp/dist/ntpd/ntp_control.c:3600:2: note: in expansion of macro 'EVP_DigestInit'
  EVP_DigestInit(ctx, EVP_get_digestbynid(NID_md5));
  ^
cc1: all warnings being treated as errors
*** [ntp_control.o] Error code 1

	
>How-To-Repeat:
Do a 'build.sh release' with MKCRYPTO=no
	
>Fix:
Unknown.  As there are objections to deprecating the MKCRYPTO=no option
(due to several countries having crypto-import restrictions), we need to
maintain a functioning MKCRYPTO=no build.
	

>Unformatted: