Re: kern/52462: aac driver (and possibly others) needs MPification

[mlelstv%serpens.de@localhost (Michael van Elst)]

The following reply was made to PR kern/52462; it has been noted by GNATS.

From: mlelstv%serpens.de@localhost (Michael van Elst)
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/52462: aac driver (and possibly others) needs MPification
Date: Sat, 5 Aug 2017 05:44:57 -0000 (UTC)

 he%NetBSD.org@localhost (Havard Eidnes) writes:
 
 > Hm, the list of drivers 'below' ld is incomplete at best,
 > e.g. twa.c also uses splbio() for mutual exclusion.
 > 
 > So if the missing concurrency protection is indeed what caused
 > the problem in the first place, there are more drivers in need of
 > repair.
 
 These are the drivers behind ld(4):
 
 ./arch/usermode/dev/ld_thunkbus.c
 ./dev/ata/ld_ataraid.c
 ./dev/i2o/ld_iop.c
 ./dev/ic/ld_nvme.c
 ./dev/ic/ld_aac.c
 ./dev/ic/ld_cac.c
 ./dev/ic/ld_icp.c
 ./dev/ic/ld_mlx.c
 ./dev/pci/ld_amr.c
 ./dev/pci/ld_twa.c
 ./dev/pci/ld_twe.c
 ./dev/pci/ld_virtio.c
 ./dev/sdmmc/ld_sdmmc.c
 
 nvme and sdmmc are ok. virtio, iop, cac also look good.
 
 But if that's everything, then wrapping the aac driver entry
 with kernel lock should have been sufficient.
 
 -- 
 -- 
                                 Michael van Elst
 Internet: mlelstv%serpens.de@localhost
                                 "A potential Snark may lurk in every tree."