re: kern/52468: ISA DMA incorrectly maps I/O port 0x80 for page address registers

[matthew green <mrg%eterna.com.au@localhost>]

The following reply was made to PR kern/52468; it has been noted by GNATS.

From: matthew green <mrg%eterna.com.au@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
    netbsd-bugs%netbsd.org@localhost, glitch%glitchwrks.com@localhost
Subject: re: kern/52468: ISA DMA incorrectly maps I/O port 0x80 for page address registers
Date: Tue, 08 Aug 2017 05:09:23 +1000

 thanks for looking into this.
 
 >  -static int dmapageport[2][4] = {
 >  -	{0x7, 0x3, 0x1, 0x2},
 >  -	{0xf, 0xb, 0x9, 0xa}
 >  +static const int dmapageport[2][4] = {
 >  +	{0x87, 0x83, 0x81, 0x82},
 >  +	{0x8f, 0x8b, 0x89, 0x8a}
 >   };
 [ ... ]
 >   		bus_space_write_1(ids->ids_bst, ids->ids_dmapgh,
 >  -		    dmapageport[0][ochan], (dmaaddr >> 16) & 0xff);
 >  +		    dmapageport[0][ochan] - IO_DMAPG, (dmaaddr >> 16) & 0xff);
 
 i would rather see this where dmapageport[] values are simply
 reduced by 1 and then bus_space accesses remain as-is.
 
 thanks!
 
 
 .mrg.