Re: toolchain/52482: Broken makefile include order?

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR toolchain/52482; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: toolchain/52482: Broken makefile include order?
Date: Mon, 14 Aug 2017 10:24:00 +0200

 On Sun, Aug 13, 2017 at 09:40:01PM +0000, Joerg Sonnenberger wrote:
 >  Hm. OK, that's a problem. The other question is what exactly is
 >  triggering the evaluation of CFLAGS before bsd.own.mk is included?
 >  The definition itself is lazy and not evaluated immediately.
 
 sys/arch/sparc/stand/Makefile.inc adds to CFLAGS, so before bsd.own.mk
 comes in.
 
 So the other option is to not set CFLAGS but COPTS there (which 
 also seems to work)
 
 Index: Makefile.inc
 ===================================================================
 RCS file: /cvsroot/src/sys/arch/sparc/stand/Makefile.inc,v
 retrieving revision 1.14
 diff -u -r1.14 Makefile.inc
 --- Makefile.inc	1 Oct 2016 13:57:44 -0000	1.14
 +++ Makefile.inc	14 Aug 2017 08:23:38 -0000
 @@ -8,7 +8,7 @@
  NOPIE=		yes
  
  CPPFLAGS+=	-DSTANDALONE -I.
 -CFLAGS+=	-ffreestanding ${${ACTIVE_CC} == "gcc":? -msoft-float :}
 +COPTS+=	-ffreestanding ${${ACTIVE_CC} == "gcc":? -msoft-float :}
  
  .if ${MACHINE} == "sparc64"
  CPPFLAGS+=	-DSUN4U
 
 
 Martin