Re: kern/52074: -current npf map directive broken

[David Holland <dholland-bugs%netbsd.org@localhost>]

The following reply was made to PR kern/52074; it has been noted by GNATS.

From: David Holland <dholland-bugs%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/52074: -current npf map directive broken
Date: Mon, 12 Mar 2018 00:22:25 +0000

 Not sent to gnats.
 
    ------
 
 From: Mindaugas Rasiukevicius <rmind%netbsd.org@localhost>
 To: Frank Kardel <kardel%netbsd.org@localhost>
 Cc: Roy Marples <roy%marples.name@localhost>, Robert Elz <kre%munnari.OZ.AU@localhost>,
 	netbsd-bugs%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, Christos Zoulas
 	<christos%NetBSD.org@localhost>, Martin Husemann <martin%duskware.de@localhost>, Joerg
 	Sonnenberger <joerg%bec.de@localhost>
 Subject: Re: kern/52074: -current npf map directive broken
 Date: Sun, 10 Dec 2017 00:31:09 +0000
 
 Frank Kardel <kardel%netbsd.org@localhost> wrote:
 > Hi Roy !
 > 
 > Would be possible, but I think we are not gaining any benefit from the 
 > additional look-up.
 > Before the packet filter we see the originating interface. That is the 
 > one for which we need to count the bytes sent.
 > After the packet filter we see either no change most of the time, some 
 > other local interface or nothing.
 > So I would prefer just to look the the originating interface.
 > 
 > There is one subtle case for not being able to find the correct local 
 > interface from the source address.
 > In BSD multiple interfaces can have the same IP address. In this 
 > situation we cannot correctly determine
 > the correct interface from the source address alone for bytes-sent 
 > accounting.
 > As this didn't work properly up to now we are not making things worse 
 > with respect to bytes-sent accounting.
 > 
 
 AFAIK this fixed in -current, right?
 
 -- 
 Mindaugas
 
 
 From: Roy Marples <roy%marples.name@localhost>
 To: Mindaugas Rasiukevicius <rmind%netbsd.org@localhost>, Frank Kardel
 	<kardel%netbsd.org@localhost>
 Cc: Robert Elz <kre%munnari.OZ.AU@localhost>, netbsd-bugs%netbsd.org@localhost,
 	gnats-admin%netbsd.org@localhost, Christos Zoulas <christos%NetBSD.org@localhost>, Martin
 	Husemann <martin%duskware.de@localhost>, Joerg Sonnenberger <joerg%bec.de@localhost>
 Subject: Re: kern/52074: -current npf map directive broken
 Date: Sun, 10 Dec 2017 10:43:37 +0000
 
 On 10/12/2017 00:31, Mindaugas Rasiukevicius wrote:
 > Frank Kardel <kardel%netbsd.org@localhost> wrote:
 > > Hi Roy !
 > > 
 > > Would be possible, but I think we are not gaining any benefit from the
 > > additional look-up.
 > > Before the packet filter we see the originating interface. That is the
 > > one for which we need to count the bytes sent.
 > > After the packet filter we see either no change most of the time, some
 > > other local interface or nothing.
 > > So I would prefer just to look the the originating interface.
 > > 
 > > There is one subtle case for not being able to find the correct local
 > > interface from the source address.
 > > In BSD multiple interfaces can have the same IP address. In this
 > > situation we cannot correctly determine
 > > the correct interface from the source address alone for bytes-sent
 > > accounting.
 > > As this didn't work properly up to now we are not making things worse
 > > with respect to bytes-sent accounting.
 > > 
 > 
 > AFAIK this fixed in -current, right?
 > 
 
 Christos fixed if in sys/netinet/ip_output -r1.277
 
 Roy
 
 
 From: Frank Kardel <kardel%netbsd.org@localhost>
 To: Roy Marples <roy%marples.name@localhost>, Mindaugas Rasiukevicius <rmind%netbsd.org@localhost>
 Cc: Robert Elz <kre%munnari.OZ.AU@localhost>, netbsd-bugs%netbsd.org@localhost,
 	gnats-admin%netbsd.org@localhost, Christos Zoulas <christos%NetBSD.org@localhost>, Martin
 	Husemann <martin%duskware.de@localhost>, Joerg Sonnenberger <joerg%bec.de@localhost>
 Subject: Re: kern/52074: -current npf map directive broken
 Date: Sun, 10 Dec 2017 11:48:42 +0100
 
 Yes the current ip_output is fixed in that regard.
 
 Frank