re: port-mips/52892: Tests hang on MIPS

[matthew green <mrg%eterna.com.au@localhost>]

The following reply was made to PR port-mips/52892; it has been noted by GNATS.

From: matthew green <mrg%eterna.com.au@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: port-mips-maintainer%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
    netbsd-bugs%netbsd.org@localhost, gson%gson.org@localhost (Andreas Gustafsson)
Subject: re: port-mips/52892: Tests hang on MIPS
Date: Mon, 23 Apr 2018 02:57:10 +1000

 >  Index: kern_condvar.c
 >  ===================================================================
 >  RCS file: /cvsroot/src/sys/kern/kern_condvar.c,v
 >  retrieving revision 1.41
 >  diff -u -r1.41 kern_condvar.c
 >  --- kern_condvar.c	30 Jan 2018 07:52:22 -0000	1.41
 >  +++ kern_condvar.c	22 Apr 2018 16:12:19 -0000
 >  @@ -268,9 +268,10 @@
 >   
 >   	KASSERT(mutex_owned(mtx));
 >   
 >  -	cv_enter(cv, mtx, l);
 >  +	CV_LOCKDEBUG_HANDOFF(l, cv);
 >   	error = sleepq_block(0, true);
 >  -	return cv_exit(cv, mtx, l, error);
 >  +	mutex_enter(mtx);
 >  +	return error;
 >   }
 
 this can't be right.  you've removed cv_enter() entirely,
 and the cv_exit() only means we don't potentially cv_signal()
 something.  perhaps this is proc_lock being held issue, ie,
 is that the only place it could hang here?
 
 
 .mrg.