NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: kern/53217: -current: dumping to wedges on GPT disks broken
The following reply was made to PR kern/53217; it has been noted by GNATS.
From: John Nemeth <jnemeth%cue.bc.ca@localhost>
To: gnats-bugs%NetBSD.org@localhost, kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
netbsd-bugs%netbsd.org@localhost, kardel%netbsd.org@localhost
Cc:
Subject: Re: kern/53217: -current: dumping to wedges on GPT disks broken
Date: Thu, 3 May 2018 11:26:24 -0700
On Apr 27, 7:45am, Martin Husemann wrote:
}
} The following reply was made to PR kern/53217; it has been noted by GNATS.
}
} From: Martin Husemann <martin%duskware.de@localhost>
} To: gnats-bugs%NetBSD.org@localhost
} Cc:
} Subject: Re: kern/53217: -current: dumping to wedges on GPT disks broken
} Date: Fri, 27 Apr 2018 09:42:05 +0200
}
} On Thu, Apr 26, 2018 at 07:10:00PM +0000, kardel%netbsd.org@localhost wrote:
} > >Fix:
} > Maybe also accept FS_UNUSED as fstype?
}
} I'd rather have the dkwedge_gpt.c code set the partition type of the
} fake label for the whole disk of the wedge to FS_SWAP when dkw.dkw_ptype
} is DKW_PTYPE_SWAP.
Should we be migrating away from the use of labels as an API
and have them as only a low level detail that gets buried and only
seen by utility apps? We already have DIOCGSECTORSIZE and
DIOCGMEDIASIZE. Maybe we need something like DIOCGPARTTYPE as a
generic way to get a partition type without needing to know anything
about the underlying partition scheme?
}-- End of excerpt from Martin Husemann
Home |
Main Index |
Thread Index |
Old Index