Re: kern/53546: ifconfig tapXXXXX problem (wrong unit name or panic)

[christos%zoulas.com@localhost (Christos Zoulas)]

The following reply was made to PR kern/53546; it has been noted by GNATS.

From: christos%zoulas.com@localhost (Christos Zoulas)
To: Robert Elz <kre%munnari.OZ.AU@localhost>
Cc: gnats-bugs%NetBSD.org@localhost, kern-bug-people%netbsd.org@localhost, 
	gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost, msaitoh%execsw.org@localhost
Subject: Re: kern/53546: ifconfig tapXXXXX problem (wrong unit name or panic)
Date: Fri, 24 Aug 2018 11:17:36 -0400

 On Aug 24,  7:08pm, kre%munnari.OZ.AU@localhost (Robert Elz) wrote:
 -- Subject: Re: kern/53546: ifconfig tapXXXXX problem (wrong unit name or pan
 
 |     Date:        Fri, 24 Aug 2018 06:06:06 -0400
 |     From:        christos%zoulas.com@localhost (Christos Zoulas)
 |     Message-ID:  <20180824100606.0CFF417FDA1%rebar.astron.com@localhost>
 | 
 |   | Why don't we make cf_unit and dv_unit unsigned int?
 | 
 | Even if there was enough minor unit number space to support that,
 | all it is doing is altering the values at which weirdness appears.
 | 
 | I cannot imagine a use case for > 30000 pseudo devices of any
 | type (or any other kind of interface or device) - the closest I can
 | see if with vlans where it is nice to be able to have the vlan number
 | and the interface number matching - but that takes just 12 bits.
 | 
 
 So dv_unit is and int already... minor() which is used for dv_unit
 is uint32_t already. There are no meaningful uses for negative
 dv_unit or cf_unit and they are compared directly to ceach other
 on many places. Instead of adding checks for truncation it is easier
 to widen them and make them the same size (meaningful or not). So
 I suggest that both become uint32_t.
 
 Best,
 
 christos