Re: port-sgimips/53583: sysinst in NetBSD/sgimips 8.0 doesn'tinstall bootloader

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR port-sgimips/53583; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: tsutsui%ceres.dti.ne.jp@localhost
Subject: Re: port-sgimips/53583: sysinst in NetBSD/sgimips 8.0 doesn'tinstall
 bootloader
Date: Sat, 8 Sep 2018 20:07:14 +0200

 On Sat, Sep 08, 2018 at 02:45:01PM +0000, Izumi Tsutsui wrote:
 >  The dmesg is a new installation to disk which has 5.2.3 installation
 >  with the same partition. (actually sgivol is not called after disklabel)
 
 Hmm, the sgimips machdep code fetches the name of the booted kernel
 in md_init_set_status:
 
         /*
          * Get the name of the Install Kernel we are running under and
          * enable the installation of the corresponding GENERIC kernel.
          */
         uname(&instsys);
         if (strstr(instsys.version, "(INSTALL32_IP3x"))
                 set_kernel_set(SET_KERNEL_2);
         else if (strstr(instsys.version, "(INSTALL32_IP2x"))
                 set_kernel_set(SET_KERNEL_1);
         else if (strstr(instsys.version, "(GENERIC32_IP12"))
                 set_kernel_set(SET_KERNEL_3);
 
 and also use that post-disklabel:
 
 int
 md_post_disklabel(void)
 {  
     if (strstr(instsys.version, "(INSTALL32_IP3x"))
                 return run_program(RUN_DISPLAY,
                     "%s %s", "/usr/mdec/sgivol -f -w boot /usr/mdec/ip3xboot",
                     pm->diskdev);
 ..
 
 
 but does not get the kernel name here itself. So we get all zeros and don't
 match the name, as md_init_set_status is called much later (after the
 user selected which type of installation they will do, Full, Minimal,
 with X, ...).
 
 Can you test -current? I'll commit a fix in a minute.
 
 Martin