Re: bin/54222: mount_portal(8) invalid free() after src/sbin/mount_portal/puffs_portal.c,-r1.9

[Robert Elz <kre%munnari.OZ.AU@localhost>]

The following reply was made to PR bin/54222; it has been noted by GNATS.

From: Robert Elz <kre%munnari.OZ.AU@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: bin/54222: mount_portal(8) invalid free() after src/sbin/mount_portal/puffs_portal.c,-r1.9
Date: Thu, 23 May 2019 06:27:49 +0700

 No, that's the wrong fix, I missed the
 
 	PUFFSOP_SET(pops, portal, node, reclaim);
 
 as it doesn't literally mention portal_node_reclaim ...
 
 In that case, I'd add a new func which does the same as
 portal_node_reclaim() without the two free() calls, and
 call that new func where portal_node_reclaim() is currently
 explicitly called.
 
 Either that or simply inline the two relevant lines in place
 of the portal_node_reclaim() call - we already know fd is valid
 so no need for an extra test.
 
 kre