Re: kern/54229: audio in firefox stops playing

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

The following reply was made to PR kern/54229; it has been noted by GNATS.

From: Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: isaki%pastel-flower.jp@localhost, tsutsui%ceres.dti.ne.jp@localhost
Subject: Re: kern/54229: audio in firefox stops playing
Date: Sun, 2 Jun 2019 00:22:59 +0900

 > Unless firefox expects that it stops by external operation, I think
 > that using /dev/sound in firefox is a bug, although I'm not sure
 > about pkgsrc/www/firefox history.
 > 
 > --- www/firefox/patches/patch-aa.ORIG	2018-11-12 21:50:52.000000000 +0900
 > +++ www/firefox/patches/patch-aa	2019-05-27 15:19:05.000000000 +0900
 > @@ -60,7 +60,7 @@
 >  +
 >  +    dnl Assume NetBSD implementation over SunAudio
 >  +    AC_CHECK_LIB(ossaudio, _oss_ioctl,
 > -+        [AC_DEFINE_UNQUOTED(CUBEB_OSS_DEFAULT_OUTPUT, "/dev/sound")
 > ++        [AC_DEFINE_UNQUOTED(CUBEB_OSS_DEFAULT_OUTPUT, "/dev/audio")
 >  +         MOZ_OSS_LIBS="$MOZ_OSS_LIBS -lossaudio"])
 >  +fi
 >  +CFLAGS=$_SAVE_CFLAGS
 
 I've checked where the configure.in changes came from:
 
 - patch-aa for configure.in to add OSS support has been added
   in patch-aa rev1.31:
    http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/www/firefox/patches/patch-aa#rev1.31
 
 - OSS support code seems almost identical with FreeBSD ports one:
   https://github.com/freebsd/freebsd-ports/blob/cd8036681e83301a86135acd26900d1eaf495d29/www/firefox/files/patch-bug1021761#L1192
   https://github.com/freebsd/freebsd-ports/commit/a74915b4ccb3ae9027b4d6eec4fb7a4c1e9ab10a#diff-6e3c7e25884e87dfd041a4fcf1fae6bcR1
 
 - The same changes were submitted by the author of FreeBSD ports changes
   to firefox Bugzilla, but not yet merged:
   https://bugzilla.mozilla.org/show_bug.cgi?id=1021761#c16
   https://bug1021761.bmoattachments.org/attachment.cgi?id=8488651
 
 So it's still unclear why the author (FreeBSD ports' committer?)
 chose /dev/sound (not /dev/audio) for NetBSD's OSS support.
 
 
 Note pkgsrc/mail/thunderbird* seems to have the same OSS support code:
 
 http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/mail/thunderbird/patches/patch-old-configure.in?rev=1.1&content-type=text/x-cvsweb-markup
 ---
 +    dnl Assume NetBSD implementation over SunAudio
 +    AC_CHECK_LIB(ossaudio, _oss_ioctl,
 +        [AC_DEFINE_UNQUOTED(CUBEB_OSS_DEFAULT_OUTPUT, "/dev/sound")
 +         MOZ_OSS_LIBS="$MOZ_OSS_LIBS -lossaudio"])
 ---
 Izumi Tsutsui