Re: PR/54217 CVS commit: src/sys/dev/ata

[Andrius V <vezhlys%gmail.com@localhost>]

The following reply was made to PR port-amd64/54217; it has been noted by GNATS.

From: Andrius V <vezhlys%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: port-amd64-maintainer%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
	netbsd-bugs%netbsd.org@localhost
Subject: Re: PR/54217 CVS commit: src/sys/dev/ata
Date: Fri, 7 Jun 2019 12:33:52 +0300

 Hi,
 
 Thank you for the commit, this change will definitely fix the crash
 itself, however, as I stated in the bug thread it still introduces the
 new bug. Occasionally (actually more often than not in my case) second
 hard drive is not detected properly:
 
 autoconfiguration error: ahcisata0 port 5: clearing WDCTL_RST failed for drive 0
 wd1: autoconfiguration error: IDENTIFY failed
 wd1: fixing 0 sector size
 wd1: secperunit and ncylinders are zero
 wd1(ahcisata0:5:0): using PIO mode 0
 
 I haven't observed such an issue in NetBSD 8. Should I create a
 separate PR for this?
 
 
 On Fri, Jun 7, 2019 at 12:00 AM Michael van Elst <mlelstv%netbsd.org@localhost> wrote:
 >
 > The following reply was made to PR port-amd64/54217; it has been noted by GNATS.
 >
 > From: "Michael van Elst" <mlelstv%netbsd.org@localhost>
 > To: gnats-bugs%gnats.NetBSD.org@localhost
 > Cc:
 > Subject: PR/54217 CVS commit: src/sys/dev/ata
 > Date: Thu, 6 Jun 2019 20:55:43 +0000
 >
 >  Module Name:   src
 >  Committed By:  mlelstv
 >  Date:          Thu Jun  6 20:55:43 UTC 2019
 >
 >  Modified Files:
 >         src/sys/dev/ata: wd.c
 >
 >  Log Message:
 >  Take channel lock for calling reset_drive.
 >  Should fix PR 54217.
 >
 >
 >  To generate a diff of this commit:
 >  cvs rdiff -u -r1.451 -r1.452 src/sys/dev/ata/wd.c
 >
 >  Please note that diffs are not public domain; they are subject to the
 >  copyright notices on the relevant files.
 >