Re: lib/54329: libedit: undefined terminal behavior in terminal_move_to_line (fix included)

[Raphael 'kena' Poss <knz%thaumogen.net@localhost>]

The following reply was made to PR lib/54329; it has been noted by GNATS.

From: Raphael 'kena' Poss <knz%thaumogen.net@localhost>
To: Jordan Lewis <jordan%cockroachlabs.com@localhost>, gnats-bugs%netbsd.org@localhost
Cc: Nikhil Benesch <nikhil.benesch%gmail.com@localhost>
Subject: Re: lib/54329: libedit: undefined terminal behavior in
 terminal_move_to_line (fix included)
Date: Sat, 29 Jun 2019 09:05:46 +0200

 On 28-06-19 15:55, Jordan Lewis wrote:
 > The reason we started messing with this is that if you try to restore a
 > history entry that's taller than 2 lines when the cursor is at the
 > bottom of the screen, the program tries to use T_DO to move the cursor,
 > which has no effect, so it ends up overwriting the bottom line with the
 > contents of all of the lines of the multi-line history entry.
 
 For reference I have tried this (recalling 2 lines of history at the
 bottom of the terminal, with libedit) on the following terminals:
 
 - st
 - lxterm
 - xfce4-terminal
 - xterm
 
 and I observe no issue whatsoever. also used `tput cud 5` on the last
 line and observed no badness.
 
 Like the other commenter, I suspect you have a different problem.
 (Or perhaps you need to record your screen to show more precisely what
 is happening)
 
 I would recommend checking the following:
 
 - that the TERM env var is set properly for your terminal. Possibly you
 need to change it.
 - if you are using `screen` or `tmux`, bring it up to date.
 - if you are using `screen` or `tmux`, ensure BOTH that:
   - the TERM env var *outside* of the session manager matches your
 terminal emulator.
   - the TERM env var *inside* of the session manager is properly set to,
 respectively, "screen" or "tmux".
 
 
 -- 
 Raphael 'kena' Poss