Re: misc/53561: Build log contains gmake debug output

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR misc/53561; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: Andreas Gustafsson <gson%gson.org@localhost>
Cc: gnats-bugs%netbsd.org@localhost, matthew green <mrg%eterna.com.au@localhost>
Subject: Re: misc/53561: Build log contains gmake debug output
Date: Wed, 13 Nov 2019 17:37:18 +0100

 On Wed, Nov 13, 2019 at 06:25:50PM +0200, Andreas Gustafsson wrote:
 > Martin Husemann wrote:
 > > Yeah, -j triggering the match, but how does the directory get into
 > > MAKEFLAGS, and what triggers it in the bracket case?
 > 
 > PR 54456 shows the contents of MAKEFLAGS, which contains three copies of
 > the build directory name, by way of -m, _SRC_TOP_, and _SRC_TOP_OBJ_:
 > 
 >    -d e -m /tmp/bracket/build/2019.08.08.14.00.32-amd64-job-000014/src/share/mk -j 12 -J 15,16 .MAKE.LEVEL.ENV=MAKELEVEL HOST_OSTYPE=NetBSD-8.1-amd64 MKOBJDIRS=yes _SRC_TOP_=/tmp/bracket/build/2019.08.08.14.00.32-amd64-job-000014/src _SRC_TOP_OBJ_=/tmp/bracket/build/2019.08.08.14.00.32-amd64-job-000014/obj _THISDIR_=tools/
 > 
 > > Can you try modifying the next line to echo some debug data, like:
 > > 
 > > GMAKE_J_ARGS?=  ${MAKEFLAGS:[*]:M*-j*:C/.*(-j ?[0-9]*).*/\1/W}
 > > BUILD_COMMAND=  echo "MAKEFLAGS: ${MAKEFLAGS}; echo "GMAKE_J_ARGS: ${GMAKE_J_ARGS}; /usr/bin/env -i ${BUILD_ENV} ${MAKE_ARGS} ${TOOL_GMAKE} ${GMAKE$
 > > 
 > > and grep for that in a bracket log?
 > 
 > I can't parse the final "${GMAKE$", please (re)send me the exact
 > BUILD_COMMAND you would like me to use.
 
 Ooops, copy + pasto...
 
 
 Index: Makefile.gnuhost
 ===================================================================
 RCS file: /cvsroot/src/tools/Makefile.gnuhost,v
 retrieving revision 1.51
 diff -u -r1.51 Makefile.gnuhost
 --- Makefile.gnuhost	22 Oct 2018 13:19:42 -0000	1.51
 +++ Makefile.gnuhost	13 Nov 2019 16:30:57 -0000
 @@ -96,7 +96,7 @@
  # sub-gmake's get them, otherwise tools/gcc tries to build libgcc and
  # fails.  it also uses "env -i" to entirely clear out MAKEFLAGS.
  GMAKE_J_ARGS?=	${MAKEFLAGS:[*]:M*-j*:C/.*(-j ?[0-9]*).*/\1/W}
 -BUILD_COMMAND=	/usr/bin/env -i ${BUILD_ENV} ${MAKE_ARGS} ${TOOL_GMAKE} ${GMAKE_J_ARGS} -e ${MAKE_ARGS}
 +BUILD_COMMAND=	echo "MAKEFLAGS: ${MAKEFLAGS}; echo "GMAKE_J_ARGS: ${GMAKE_J_ARGS}; /usr/bin/env -i ${BUILD_ENV} ${MAKE_ARGS} ${TOOL_GMAKE} ${GMAKE_J_ARGS} -e ${MAKE_ARGS}
  
  .endif
  
 Martin