Re: lib/54350: lib/libcurses/t_curses/mvscanw test fails

[Andreas Gustafsson <gson%gson.org@localhost>]

The following reply was made to PR lib/54350; it has been noted by GNATS.

From: Andreas Gustafsson <gson%gson.org@localhost>
To: Brett Lymn <blymn%internode.on.net@localhost>
Cc: gnats-bugs%netbsd.org@localhost
Subject: Re: lib/54350: lib/libcurses/t_curses/mvscanw test fails
Date: Thu, 6 Feb 2020 19:19:09 +0200

 On Oct 4, 2019 Brett Lymn wrote:
 >  Can you please re-test.  During the process of adding wide character
 >  support to the curse test frame I found errors in how variables were
 >  being handled when creating the arguments for a call.
 >  
 >  the mvscanw tests runs to completion with MKSANITIZE=yes now.
 
 I re-tested on amd64 using today's current, re-enabling JEMALLOC_DEBUG
 using this patch:
 
 Index: src/external/bsd/jemalloc/lib/Makefile.inc
 ===================================================================
 RCS file: /bracket/repo/src/external/bsd/jemalloc/lib/Makefile.inc,v
 retrieving revision 1.10
 retrieving revision 1.9
 diff -u -r1.10 -r1.9
 --- src/external/bsd/jemalloc/lib/Makefile.inc	23 Jul 2019 06:31:20 -0000	1.10
 +++ src/external/bsd/jemalloc/lib/Makefile.inc	15 Apr 2019 20:40:53 -0000	1.9
 @@ -38,10 +38,7 @@
  .SUFFIXES: .3
  .PATH.3: ${JEMALLOC}/dist/doc
  .for i in ${JEMALLOC_SRCS}
 -# helps in tracking bad malloc/pointer usage, but has a serious
 -# performance penalty:
 -#   CPPFLAGS.${i}+=-I${JEMALLOC}/include -DJEMALLOC_PROTECT_NOSTD -DJEMALLOC_DEBUG
 -CPPFLAGS.${i}+=-I${JEMALLOC}/include -DJEMALLOC_PROTECT_NOSTD
 +CPPFLAGS.${i}+=-I${JEMALLOC}/include -DJEMALLOC_PROTECT_NOSTD -DJEMALLOC_DEBUG
  COPTS.${i}+= -fvisibility=hidden -funroll-loops
  COPTS.${i}+= ${${ACTIVE_CC} == "clang":? -Wno-atomic-alignment :}
  .endfor
 
 The test still failed.  Log output is at:
 
   http://www.gson.org/netbsd/bugs/build/amd64-debug-baremetal/2020/2020.02.06.10.47.33/test.html#lib_libcurses_t_curses_mvscanw
 
 Next time please set the PR to the feedback state, it may help get a
 faster response.
 -- 
 Andreas Gustafsson, gson%gson.org@localhost