re: kern/54976: radeon framebuffer fails initialization in NetBSD-9

[matthew green <mrg%eterna.com.au@localhost>]

OK, i think i see the real problem.

quick survey of the request_firmware() calls in radeon
shows that most attempt both names, eg:

        case CHIP_KAVERI:
                chip_name = "KAVERI";
                new_chip_name = "kaveri";
...
        snprintf(fw_name, sizeof(fw_name), "radeon/%s_pfp.bin", new_chip_name);
        err = request_firmware(&rdev->pfp_fw, fw_name, rdev->dev);
        if (err) {
                snprintf(fw_name, sizeof(fw_name), "radeon/%s_pfp.bin", chip_name);
                err = request_firmware(&rdev->pfp_fw, fw_name, rdev->dev);
...

but the KAVERI path doesn't look for old chip_name:

        if (rdev->family == CHIP_KAVERI) {
                snprintf(fw_name, sizeof(fw_name), "radeon/%s_mec2.bin", new_chip_name);
                err = request_firmware(&rdev->mec2_fw, fw_name, rdev->dev);
                if (err) {
                        goto out;

i guess this just needs to also check both names.


.mrg.