PR/54897 CVS commit: src/sys/rump/net/lib/libshmif

["Ryota Ozaki" <ozaki-r%netbsd.org@localhost>]

The following reply was made to PR kern/54897; it has been noted by GNATS.

From: "Ryota Ozaki" <ozaki-r%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/54897 CVS commit: src/sys/rump/net/lib/libshmif
Date: Thu, 20 Feb 2020 08:06:16 +0000

 Module Name:	src
 Committed By:	ozaki-r
 Date:		Thu Feb 20 08:06:15 UTC 2020
 
 Modified Files:
 	src/sys/rump/net/lib/libshmif: if_shmem.c
 
 Log Message:
 shmif: use cprng_strong32 to generate random bytes for a MAC address
 
 cprng_fast32 sometimes returns indentical bytes, which look
 "20:0e:11:33" in a MAC address, on different rump_server instances.
 That leads MAC address duplications resulting in a test failure.
 
 Fix it by using cprng_strong32 instead of cprng_fast32.  However
 we should rather fix cprng_fast32 (or rump itself) somehow.
 
 The fix mitigates PR kern/54897 but test failures due to other
 causes still remain.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.77 -r1.78 src/sys/rump/net/lib/libshmif/if_shmem.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.