Re: lib/55118: Recent change in terminal output breaks anita

[Christos Zoulas <christos%zoulas.com@localhost>]

The following reply was made to PR lib/55118; it has been noted by GNATS.

From: Christos Zoulas <christos%zoulas.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: lib-bug-people%netbsd.org@localhost,
 gnats-admin%netbsd.org@localhost,
 netbsd-bugs%netbsd.org@localhost
Subject: Re: lib/55118: Recent change in terminal output breaks anita
Date: Sat, 28 Mar 2020 11:13:04 -0400

 --Apple-Mail=_09EC6E28-303F-4754-A927-C92FC62B9E4D
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/plain;
 	charset=us-ascii
 
 It does:
 Shall<reset-attrs><cursor =
 right><foreground-white><background-blue>we<reset-attrs><cursor-right><for=
 eground-white><background-blue>continue?
 
 I *think* this is because the xterm-color (if I am guessing right) now =
 clamps color pair entries instead of truncating them.
 
 Can you try:
 1. using a terminal that does not support color.
 2. applying this patch
 
 Index: term_private.h
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /cvsroot/src/lib/libterminfo/term_private.h,v
 retrieving revision 1.14
 diff -u -p -u -r1.14 term_private.h
 --- term_private.h      27 Mar 2020 17:39:53 -0000      1.14
 +++ term_private.h      28 Mar 2020 15:11:58 -0000
 @@ -273,8 +273,7 @@ static __inline void
  _ti_encode_buf_num(TBUF *tbuf, size_t num, int rtype)
  {
         if (rtype =3D=3D TERMINFO_RTYPE_O1) {
 -               if (num > SHRT_MAX)
 -                       num =3D SHRT_MAX;
 +               num &=3D 0xffff;
                 _ti_encode_buf_16(tbuf, num);
         } else {
                 _ti_encode_buf_32(tbuf, num);
 
 
 christos
 
 
 --Apple-Mail=_09EC6E28-303F-4754-A927-C92FC62B9E4D
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
 	filename=signature.asc
 Content-Type: application/pgp-signature;
 	name=signature.asc
 Content-Description: Message signed with OpenPGP
 
 -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - http://gpgtools.org
 
 iF0EARECAB0WIQS+BJlbqPkO0MDBdsRxESqxbLM7OgUCXn9pgAAKCRBxESqxbLM7
 OjlvAJ9yxavru76gm2BaJIKGgWzmWYo8HACcCvmw7ZZGL96rR9UbLgWnm2sdtJE=
 =24qP
 -----END PGP SIGNATURE-----
 
 --Apple-Mail=_09EC6E28-303F-4754-A927-C92FC62B9E4D--