Re: PR/55595 CVS commit: src/tests/usr.bin/make

[Andreas Gustafsson <gson%gson.org@localhost>]

The following reply was made to PR misc/55595; it has been noted by GNATS.

From: Andreas Gustafsson <gson%gson.org@localhost>
To: "Robert Elz" <kre%netbsd.org@localhost>
Cc: gnats-bugs%netbsd.org@localhost
Subject: Re: PR/55595 CVS commit: src/tests/usr.bin/make
Date: Sun, 4 Oct 2020 14:08:15 +0300

 On Sep 10, Robert Elz committed:
 >  Modified Files:
 >  	src/tests/usr.bin/make: t_make.sh
 >  
 >  Log Message:
 >  Replace use of tr to translate '-' in test names into '_' to satisfy ATF
 >  requirements (correct sh variable/function name syntax).  Use a sh
 >  loop instead, and save one fork() one vfork() and one exec of tr for
 >  each test case (many of which don't need anything done to them at all).
 >  
 >  This might partially mitigate PR misc/55595
 >  
 >  
 >  To generate a diff of this commit:
 >  cvs rdiff -u -r1.9 -r1.10 src/tests/usr.bin/make/t_make.sh
 
 Thanks.  On the TNF evbarm-aarch64 testbed, this speeded up the t_make
 test by more than a factor of 10, from 17441 seconds to 1590 seconds,
 dropping it from number 1 to number 10 on the list of tests taking the
 longest to run.  I think this is good enough that the PR can be
 closed.  If the number of test cases grows enough to again make this a
 major problem, the PR can be reopened.
 -- 
 Andreas Gustafsson, gson%gson.org@localhost