bin/55795: syslogd dies recursively

[dholland%NetBSD.org@localhost]

>Number:         55795
>Category:       bin
>Synopsis:       syslogd dies recursively
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Nov 07 22:55:00 +0000 2020
>Originator:     David A. Holland
>Release:        NetBSD 9.99.49 (20200310)
>Organization:
>Environment:
System: NetBSD valkyrie 9.99.49 NetBSD 9.99.49 (VALKYRIE) #0: Fri Oct  2 15:00:22 EDT 2020  dholland@valkyrie:/y/objects/usrobj-amd64/sys/arch/amd64/compile/VALKYRIE amd64
Architecture: x86_64
Machine: amd64
>Description:

syslogd's die() (in syslogd.c) contains a recursive call to itself if
closing a udp socket fails. This is currently (-r1.135) on line 3017.

It looks like most but not all of the cleanup code is idempotent, so
if this path is ever reached it will probably SIGSEGV.

>How-To-Repeat:

Code reading.

>Fix:

Change the close call to (void)close like the others, I guess. Anyone
have contrary opinions?