Re: lib/55220: Possible color problem in curses and/or py-curses

[Thomas Klausner <wiz%NetBSD.org@localhost>]

The following reply was made to PR lib/55220; it has been noted by GNATS.

From: Thomas Klausner <wiz%NetBSD.org@localhost>
To: Brett Lymn <blymn%internode.on.net@localhost>
Cc: gnats-bugs%netbsd.org@localhost
Subject: Re: lib/55220: Possible color problem in curses and/or py-curses
Date: Mon, 6 Dec 2021 17:38:52 +0100

 On Mon, Dec 06, 2021 at 07:40:58AM +1030, Brett Lymn wrote:
 > On Sat, Dec 04, 2021 at 09:24:42PM +0100, Thomas Klausner wrote:
 > > 
 > > I tried fileobj with this, and I still see some weirdness (but perhaps
 > > that is what you meant with the colour pair 0 question?):
 > > 
 > 
 > Yes, that is what I was talking about.  I am sure it works fine in ncurses I suspect because
 > the ncurses chgat() won't update the colour if the pair number is 0.  I am sure our colour
 > handling is correct because the output matches screenshots out on the internet, chgat is
 > only called when the cursor moves.  I will have a look at the chgat code now the attributes
 > are coming through.
 
 Ok, thanks. Let me know if the python code needs more changes.
 
 > > As for the patch itself: The color part should be fine to upstream,
 > > since ncurses chgat(3) also documents PAIR_NUMBER. However, I can't
 > > find __ATTRIBUTES in the ncurses man pages nor headers. Is there a
 > > different way to get that?
 > > 
 > 
 > Try A_ATTRIBUTES instead, that is defined in both NetBSD curses and ncurses.
 
 Thanks! I've added that to python39 and sent it upstream.
  Thomas