Re: kern/56772: various modules cannot load - missing symbols

[Paul Goyette <paul%whooppee.com@localhost>]

The following reply was made to PR kern/56772; it has been noted by GNATS.

From: Paul Goyette <paul%whooppee.com@localhost>
To: Brad Spencer <brad%anduin.eldar.org@localhost>
Cc: gnats-bugs%netbsd.org@localhost, kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
    netbsd-bugs%netbsd.org@localhost
Subject: Re: kern/56772: various modules cannot load - missing symbols
Date: Tue, 29 Mar 2022 16:34:54 -0700 (PDT)

 Yes, this probably needs to have a new dependency added for the i2c
 module.
 
 It would be great if you could handle the update, and verify that the
 other listed modules are already OK.
 
 Thanks!
 
 
 On Tue, 29 Mar 2022, Brad Spencer wrote:
 
 > paul%whooppee.com@localhost writes:
 >
 >> Module sht3xtemp'' fails to load due to reference to ``iic_use_direct_match''
 >
 > This is just a guess, but if sht3xtemp needs this, so does the
 > following:
 >
 > am2315.c
 > dbcool.c
 > hytp14.c
 > scmdi2c.c
 > sgp40.c
 > sht4x.c
 > si70xx.c
 > spdmem_i2c.c
 >
 > All of those use iic_use_direct_match() and pretty much the same MODULE
 > line and I can't see how they could have the symbol while sht3xtemp
 > didn't.  I think all that would be needed is for "iic" to be included as
 > a dependency in the MODULE lines.  I can't test this personally right
 > now, however.  I know I successfully modload'ed sht3xtemp (and
 > sht4xtemp, si70xxtemp and sgp40mox) while I was developing those drivers
 > as that is my typical way to test things.  However, it is entirely
 > possible that the iic module was already present in the kernel and/or
 > already loaded otherwise and I didn't notice the dependency.
 >
 > There are other drivers in src/sys/dev/i2c that use
 > iic_use_direct_match() but none of the rest appear to be configured to
 > be a module.
 >
 >
 > -- 
 > Brad Spencer - brad%anduin.eldar.org@localhost - KC8VKS - http://anduin.eldar.org
 >
 >
 > !DSPAM:624396b487601717019159!
 >
 >
 
 +--------------------+--------------------------+----------------------+
 | Paul Goyette       | PGP Key fingerprint:     | E-mail addresses:    |
 | (Retired)          | FA29 0E3B 35AF E8AE 6651 | paul%whooppee.com@localhost    |
 | Software Developer | 0786 F758 55DE 53BA 7731 | pgoyette%netbsd.org@localhost  |
 | & Network Engineer |                          | pgoyette99%gmail.com@localhost |
 +--------------------+--------------------------+----------------------+