Re: kern/57018: Missing VOP_BMAP() implementation for block devices on ZFS

[David Holland <dholland-bugs%netbsd.org@localhost>]

The following reply was made to PR kern/57018; it has been noted by GNATS.

From: David Holland <dholland-bugs%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/57018: Missing VOP_BMAP() implementation for block devices
 on ZFS
Date: Fri, 23 Sep 2022 01:15:51 +0000

 On Fri, Sep 23, 2022 at 01:10:02AM +0000, David Holland wrote:
  >  FWIW, this was fixed in -current when GENFS_SPECOP_ENTRIES was added.
  >  I don't think anyone recognized at the time that having bmap for
  >  devices mattered. (In fact, given that it makes no sense, I'd go so far
  >  as to argue that using it on a block device is a bug...)
 
 and if I'd read more carefully (and my copy of the initial report
 hadn't gotten lost in transit somewhere) I'd have noticed you'd
 already said that. foo.
 
 Anyway, the GENFS_SPECOP_ENTRIES (and GENFS_FIFOOP_ENTRIES) changes
 were invasive and not a good pullup candidate. We'll want to patch it,
 like this one, except that I'm not in a position to test it myself:
 
 
 Index: zfs_vnops.c
 ===================================================================
 RCS file: /cvsroot/src/external/cddl/osnet/dist/uts/common/fs/zfs/zfs_vnops.c,v
 retrieving revision 1.50.2.10
 diff -u -p -r1.50.2.10 zfs_vnops.c
 --- zfs_vnops.c	6 Jul 2021 04:22:34 -0000	1.50.2.10
 +++ zfs_vnops.c	23 Sep 2022 01:14:49 -0000
 @@ -6394,6 +6394,7 @@ const struct vnodeopv_entry_desc zfs_spe
  	{ &vop_bwrite_desc,		spec_bwrite },
  	{ &vop_print_desc,		zfs_netbsd_print },
  	{ &vop_fcntl_desc,		zfs_netbsd_fcntl },
 +	{ &vop_bmap_desc,		spec_bmap },
  	{ NULL, NULL }
  };
  
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost