install/57025: landisk sysinst should not installboot against RAWPART

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

>Number:         57025
>Category:       install
>Synopsis:       landisk sysinst should not installboot against RAWPART
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    install-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Sep 25 08:00:00 +0000 2022
>Originator:     Izumi Tsutsui
>Release:        NetBSD 9.3
>Organization:
>Environment:
System: NetBSD lantank 9.3 NetBSD 9.3 (GENERIC) #0: Thu Aug  4 15:30:37 UTC 2022  mkrepro%mkrepro.NetBSD.org@localhost:/usr/src/sys/arch/landisk/compile/GENERIC landisk
Architecture: sh3el
Machine: landisk
>Description:
Since NetBSD 9.0 and later, sysinst for landisk exec installboot
against RAWPART:

>> revision 1.9
>> date: 2019-06-22 01:57:12 +0900;  author: martin;  state: Exp;  lines: +2 -2;  commitid: kB4u7bjwl623R4sB;
>> Use the raw partition for installboot, not the root partition.

I'm not sure why this change was necessary, but sysinst 8.x and prior
installed /usr/mdec/mbr by fdisk(8) as the first loader as x86 and
bootxx_ffsvX is installed to the NetBSD partition, i.e. a partition a.

Then installboot(8) against RAWPART during upgrading to NetBSD 9.x
breaks existing bootstrap.

>How-To-Repeat:
Install NetBSD/landisk 8.x (via ustarfs install image)
and upgrade to NetBSD 9.x via sysinst.

The upgrade installation works but fails to boot:

---
SH IPL+g version 0.9, Copyright (C) 2000 Free Software Foundation, Inc.

This software comes with ABSOLUTELY NO WARRANTY; for details type `w'.
This is free software, and you are welcome to redistribute it under
certain conditions; type `l' for details.

2002/09/09 Making.  2003/10/16 I-O DATA NSD NWG Update.
266:133:33 on base clock 22.22MHz and SDRAM 4 burst. ATA boot.

A-Card ATP865 ATA controller found.
PCIC initialization done.
MASTER:48bit LBA mode support
Disk drive detected: ADATA SP310 2.3 2D3220001026 
LBA: 07740AB0
DiskSize: 64GByte
PIO MODE1
Set Transfer Mode result: 50 
A-Card ATP865 ATA controller found.
> b
Set Transfer Mode result: 50 
Initialize Device Parameters result: 50 
IDLE result: 50 

NetBSD/landisk ffsv1 Primary Bootstrap
Error: Can't open /boot.


---

That should be (i.e. /usr/mdec/mbr in the sector zero loads bootxx_ffsvX
at the top of the NetBSD partition):
---
 :

A-Card ATP865 ATA controller found.
> b
Set Transfer Mode result: 50 
Initialize Device Parameters result: 50 
IDLE result: 50 

NetBSD MBR boot

NetBSD/landisk ffsv1 Primary Bootstrap

>> NetBSD/landisk Boot, Revision 1.0 (Thu Aug  4 15:30:37 UTC 2022)
Press return to boot now, any other key for boot menu
booting hd0a:netbsd - starting in 0 
type "?" or "help" for help.
> 
---

>Fix:
Revert src/usr.sbin/sysinst/arch/landisk/md.c rev 1.9 and
install /usr/mdec/mbr via fdisk(8) as i386/amd64 ports?

At least, it should check if the target disk has a vaild fdisk partition
on upgrade.

---
Izumi Tsutsui