Re: kern/57202 (puc(4) missing support for EXAR XR17V354)

[Carl Håkan Engvall <hakan.engvall%gmail.com@localhost>]

I'm sorry about the base64 encoding. Here are the patches in plain text. 
These add support for EXAR XR17V35[248] based cards and correct a small 
typo in the code committed to HEAD, netbsd-9, and netbsd-10. Only a 
XR17V354 based card has been tested.

Index: puc.4
===================================================================
RCS file: /cvsroot/src/share/man/man4/puc.4,v
retrieving revision 1.41.2.2
diff -u -r1.41.2.2 puc.4
--- puc.4    30 Jan 2023 11:35:15 -0000    1.41.2.2
+++ puc.4    31 Jan 2023 17:00:02 -0000
@@ -89,7 +89,9 @@
 .It Tn "EXAR XR17D152 (2 port serial)"
 .It Tn "EXAR XR17D154 (4 port serial)"
 .It Tn "EXAR XR17D158 (8 port serial)"
+.It Tn "EXAR XR17V352 (2 port serial)"
 .It Tn "EXAR XR17V354 (4 port serial)"
+.It Tn "EXAR XR17V358 (8 port serial)"
 .It Tn "Exsys EX-41098 (4 port serial)"
 .It Tn "IBM 4810 SurePOS 300 Series SCC (4 port serial)"
 .It Tn "InnoSys Keyspan SX Pro (4 port serial)"


Index: pcidevs
===================================================================
RCS file: /cvsroot/src/sys/dev/pci/pcidevs,v
retrieving revision 1.1383.2.15
diff -u -r1.1383.2.15 pcidevs
--- pcidevs    30 Jan 2023 11:32:22 -0000    1.1383.2.15
+++ pcidevs    31 Jan 2023 16:55:21 -0000
@@ -3205,7 +3205,9 @@
 product EXAR XR17D152    0x0152    dual-channel Universal PCI UART
 product EXAR XR17D154    0x0154    quad-channel Universal PCI UART
 product EXAR XR17D158    0x0158    octal-channel Universal PCI UART
+product EXAR XR17V352    0x0352    dual-channel Universal PCIe UART
 product EXAR XR17V354    0x0354    quad-channel Universal PCIe UART
+product EXAR XR17V358    0x0358    octal-channel Universal PCIe UART

 /* FORE products */
 product FORE PCA200    0x0210    ATM PCA-200


Index: pucdata.c
===================================================================
RCS file: /cvsroot/src/sys/dev/pci/pucdata.c,v
retrieving revision 1.104.2.3
diff -u -r1.104.2.3 pucdata.c
--- pucdata.c    30 Jan 2023 11:35:15 -0000    1.104.2.3
+++ pucdata.c    31 Jan 2023 16:57:13 -0000
@@ -444,7 +444,18 @@
         { PUC_PORT_TYPE_COM, PCI_BAR0, 0x0600, COM_FREQ * 8 },
         },
     },
-    {   "EXAR XR17D154",
+
+    /* The XR17V35[248] use the 125MHz PCIe clock as reference clock. */
+    {   "EXAR XR17V352",
+        {    PCI_VENDOR_EXAR, PCI_PRODUCT_EXAR_XR17V352, 0, 0       },
+        {   0xffff, 0xffff, 0,      0       },
+        {
+        { PUC_PORT_TYPE_COM, PCI_BAR0, 0x0000, 125000000 },
+        { PUC_PORT_TYPE_COM, PCI_BAR0, 0x0400, 125000000 },
+        },
+    },
+
+    {   "EXAR XR17V354",
         {    PCI_VENDOR_EXAR, PCI_PRODUCT_EXAR_XR17V354, 0, 0       },
         {   0xffff, 0xffff, 0,      0       },
         {
@@ -455,6 +466,21 @@
         },
     },

+    {   "EXAR XR17V358",
+        {    PCI_VENDOR_EXAR, PCI_PRODUCT_EXAR_XR17V358, 0, 0       },
+        {   0xffff, 0xffff, 0,      0       },
+        {
+        { PUC_PORT_TYPE_COM, PCI_BAR0, 0x0000, 125000000 },
+        { PUC_PORT_TYPE_COM, PCI_BAR0, 0x0400, 125000000 },
+        { PUC_PORT_TYPE_COM, PCI_BAR0, 0x0800, 125000000 },
+        { PUC_PORT_TYPE_COM, PCI_BAR0, 0x0c00, 125000000 },
+        { PUC_PORT_TYPE_COM, PCI_BAR0, 0x1000, 125000000 },
+        { PUC_PORT_TYPE_COM, PCI_BAR0, 0x1400, 125000000 },
+        { PUC_PORT_TYPE_COM, PCI_BAR0, 0x1800, 125000000 },
+        { PUC_PORT_TYPE_COM, PCI_BAR0, 0x1c00, 125000000 },
+        },
+    },
+
     /*
      * Multi-Tech ISI5634PCI/4 4-port modem board.
      * Has a 4-channel Exar XR17C154 UART, but with bogus product ID 
in its