bin/57384: zpool import -a # coredumps with long lvm volume names.

[c%bow.st@localhost]

>Number:         57384
>Category:       bin
>Synopsis:       zpool import -a # coredumps with long lvm volume names.
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Apr 29 20:00:00 +0000 2023
>Originator:     Mathew, Cherry G.
>Release:        10.0_BETA
>Organization:
Self
>Environment:
NetBSD x200s 10.0_BETA NetBSD 10.0_BETA (GENERIC) #0: Tue Apr 25 16:17:59 UTC 2023  mkrepro%mkrepro.NetBSD.org@localhost:/usr/src/sys/arch/amd64/compile/GENERIC amd64
>Description:
I have several lvm volumes with long prefixes.

...
  ACTIVE            '/dev/zfs-cache/dom0' [10.00 GiB] inherit
  ACTIVE            '/dev/zfs-cache/byi-web' [8.00 GiB] inherit
  ACTIVE            '/dev/zfs-cache/netbsd-builder-swap' [4.00 GiB] inherit
  ACTIVE            '/dev/zfs-cache/netbsd-proxy-swap' [2.00 GiB] inherit
  ACTIVE            '/dev/zfs-cache/netbsd-webapps-swap' [4.00 GiB] inherit
...

These show up truncated in the sysctl MIB entry hw.disknames as follows:

... zfs--cache-dom0 zfs--cache-byi- zfs--cache-netb zfs--cache-netb zfs--cache-netb ...

Taylor Campbel (riastradh@) helped narrow this down to zpool being unable to handle duplicates, when it consults hw.disknames.

Please either document, or fix.
>How-To-Repeat:
x200s# zpool import -a
Assertion failed: (avl_find() succeeded inside avl_add()), file /usr/src/external/cddl/osnet/lib/libavl/../../dist/common/avl/avl.c, line 649.
[1]   Abort trap (core dumped) zpool import -a
x200s# 

>Fix: