Re: misc/57491: dhcpd segfaulting

[Tobias Nygren <tnn%NetBSD.org@localhost>]

The following reply was made to PR misc/57491; it has been noted by GNATS.

From: Tobias Nygren <tnn%NetBSD.org@localhost>
To: Martin Husemann <martin%duskware.de@localhost>
Cc: gnats-bugs%netbsd.org@localhost
Subject: Re: misc/57491: dhcpd segfaulting
Date: Wed, 26 Jul 2023 19:07:05 +0200

 On Wed, 26 Jul 2023 15:20:01 +0000 (UTC)
 Martin Husemann <martin%duskware.de@localhost> wrote:
 
 >  It seems to me that we just have to swap the order,
 >  i.e. do the isc_event_free() first before calling isc_timer_destroy().
 >  
 >  Not sure if this is any good:
 
 >                  isc_timer_destroy(&q->isc_timeout);
 >                  free_timeouts = q;
 >  +               isc_event_free(&eventp);
 
 I don't see how this changes the order.
 Did you intend to put isc_event_free two rows earlier?
 Other than that it LGTM & seems to work well.