Re: install/56467: sysinst output no longer scrolls correctly

[Julian Coleman <jdc%coris.org.uk@localhost>]

Hi,

>  As Martin intuited, this is a curses issue when scrolling on a line > the
>  max col. width. The patch below works for me, but, better have the curses
>  devs. give it a once over before committing.
>  
>  Thanks,
>  -RVP
>  
>  ---START PATCH---
>  --- lib/libcurses/addbytes.c.orig	2021-09-06 07:45:48.000000000 +0000
>  +++ lib/libcurses/addbytes.c	2021-10-28 07:41:46.402564363 +0000
>  @@ -559,6 +559,7 @@
>    				return ERR;
>    			__CTRACE(__CTRACE_INPUT,
>    			    "_cursesi_addwchar: do a scroll\n");
>  +			*x = 0;
>    			scroll(win);
>    		}
>    		newx = win->maxx - 1 + win->ch_off;
>  ---END PATCH---

I think this patch is OK - we set win->curx = 0 in scroll().  However, I
wonder if we should add if (!__NONL), as is done there [*]?

Regards,

Julian

PS.  We could probably remove NONL (and GT) because it doesn't look like
we're using them, but some other time.

[*] https://nxr.netbsd.org/xref/src/lib/libcurses/tty.c#129