NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: install/56467: sysinst output no longer scrolls correctly



The following reply was made to PR install/56467; it has been noted by GNATS.

From: RVP <rvp%SDF.ORG@localhost>
To: Julian Coleman <jdc%coris.org.uk@localhost>
Cc: gnats-bugs%netbsd.org@localhost, install-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
        netbsd-bugs%netbsd.org@localhost, Kimmo Suominen <kim%netbsd.org@localhost>
Subject: Re: install/56467: sysinst output no longer scrolls correctly
Date: Tue, 5 Sep 2023 22:43:19 +0000 (UTC)

 On Tue, 5 Sep 2023, Julian Coleman wrote:
 
 > I think this patch is OK - we set win->curx = 0 in scroll().  However, I
 > wonder if we should add if (!__NONL), as is done there [*]?
 >
 > Regards,
 >
 > Julian
 >
 > PS.  We could probably remove NONL (and GT) because it doesn't look like
 > we're using them, but some other time.
 >
 > [*] https://nxr.netbsd.org/xref/src/lib/libcurses/tty.c#129
 >
 
 Ah, I've lost all context for this, but, certainly there's an issue a few
 lines above that:
 
 https://nxr.netbsd.org/xref/src/lib/libcurses/tty.c#116
 
 It should be `screen->outfd' as per the comment just above.
 
 -RVP
 


Home | Main Index | Thread Index | Old Index