Re: toolchain/57584: Running build.sh with -N 3 or -N 4 causes debug logging to be included in the MKVARS shell variable in distrib/sets/sets.subr

[Palle Lyckegaard <palle%lyckegaard.dk@localhost>]

The following reply was made to PR toolchain/57584; it has been noted by GNATS.

From: Palle Lyckegaard <palle%lyckegaard.dk@localhost>
To: Christos Zoulas <christos%zoulas.com@localhost>
Cc: gnats-bugs%netbsd.org@localhost, toolchain-manager%netbsd.org@localhost,
        gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
Subject: Re: toolchain/57584: Running build.sh with -N 3 or -N 4 causes debug
 logging to be included in the MKVARS shell variable in
 distrib/sets/sets.subr
Date: Thu, 7 Sep 2023 17:50:16 +0000 (UTC)

 On Wed, 6 Sep 2023, Christos Zoulas wrote:
 
 > But the patch also changes the MAKEVERBOSE setting from being in the environment to being in the make command line,
 > and that will not work I think.
 >
 >> -MKVARS="$( MAKEVERBOSE= ${MAKE} -B -f ${rundir}/mkvars.mk mkvars | ${SED}
 >> -e 's,=.*,,' | ${XARGS} )"
 >> +MKVARS="$( ${MAKE} -B -f ${rundir}/mkvars.mk MAKEVERBOSE=0 mkvars |
 >> ${SED} -e 's,=.*,,' | ${XARGS} )"
 >
 > What happens if you run:
 >
 > MKVARS="$( MAKEVERBOSE=0 ${MAKE} -B -f ${rundir}/mkvars.mk mkvars | ${SED} -e 's,=.*,,' | ${XARGS} )"
 > echo "sets.subr contains: " $MKVARS
 >
 
 
 Building with the following patch (which is similar to your suggestion):
 
 diff --git a/distrib/sets/sets.subr b/distrib/sets/sets.subr
 index 6f2223181713..e74a1b0d5653 100644
 --- a/distrib/sets/sets.subr
 +++ b/distrib/sets/sets.subr
 @@ -130,6 +130,7 @@ done
   IFS=$oIFS
 
   MKVARS="$( MAKEVERBOSE= ${MAKE} -B -f ${rundir}/mkvars.mk mkvars | ${SED} 
 -e 's,=.*,,' | ${XARGS} )"
 +echo "sets.subr contains: " $MKVARS
 
   #####
 
 
 The issue pesists on both Solaris and NetBSD with the extra "echo XXXX" 
 strings.
 
 
 Solaris:
 
 ...
 + echo USE_LDAP=yes
 + echo USE_YP=yes
 + echo COMPATARCHDIRS=sparc
 + echo KMODARCHDIRS=
 + echo MKSOLARIS=yes
 sets.subr contains:  echo MKARGON2 MKARGON2 echo MKATF MKATF echo 
 MKBINUTILS MKBINUTILS echo MKBSDTAR MKBSDTAR echo MKCLEANSRC MKCLEANSRC 
 echo MKCLEANVERIFY MKCLEANVERIFY echo MKCOMPLEX MKCOMPLEX echo MKCVS MKCVS 
 echo MKCXX MKCXX echo MKDOC MKDOC echo MKDTC MKDTC echo MKDYNAMICROOT 
 MKDYNAMICROOT echo MKGCC MKGCC echo MKGDB MKGDB echo MKGROFF MKGROFF echo 
 MKHESIOD MKHESIOD echo MKHTML MKHTML echo MKIEEEFP MKIEEEFP echo MKINET6 
 MKINET6 echo MKINFO MKINFO echo MKIPFILTER MKIPFILTER echo MKISCSI MKISCSI 
 echo MKKERBEROS MKKERBEROS echo MKKMOD MKKMOD echo MKLDAP MKLDAP echo 
 MKLIBSTDCXX MKLIBSTDCXX echo MKLINKLIB MKLINKLIB echo MKLVM MKLVM echo 
 MKMAKEMANDB MKMAKEMANDB echo MKMAN MKMAN echo MKMANDOC MKMANDOC echo 
 MKMDNS MKMDNS echo MKNLS MKNLS echo MKNPF MKNPF echo MKOBJ MKOBJ echo 
 MKPAM MKPAM echo MKPF MKPF echo MKPIC MKPIC echo MKPICLIB MKPICLIB echo 
 MKPOSTFIX MKPOSTFIX echo MKPROFILE MKPROFILE echo MKRUMP MKRUMP echo 
 MKSHARE MKSHARE echo MKSKEY MKSKEY echo MKSTATICLIB MKSTATICLIB echo 
 MKSTRIPSYM MKSTRIPSYM echo MKUNBOUND MKUNBOUND echo MKX11FONTS MKX11FONTS 
 echo MKYP MKYP echo MKGCCCMDS MKGCCCMDS echo MKAMDGPUFIRMWARE 
 MKAMDGPUFIRMWARE echo MKARZERO MKARZERO echo MKBSDGREP MKBSDGREP echo 
 MKCATPAGES MKCATPAGES echo MKCOMPATTESTS MKCOMPATTESTS echo MKCOMPATX11 
 MKCOMPATX11 echo MKCTF MKCTF echo MKDEBUG MKDEBUG echo MKDEBUGLIB 
 MKDEBUGLIB echo MKDEPINCLUDES MKDEPINCLUDES echo MKDTB MKDTB echo MKDTRACE 
 MKDTRACE echo MKFIRMWARE MKFIRMWARE echo MKGROFFHTMLDOC MKGROFFHTMLDOC 
 echo MKHOSTOBJ MKHOSTOBJ echo MKKYUA MKKYUA echo MKLIBCXX MKLIBCXX echo 
 MKLINT MKLINT echo MKLLVM MKLLVM echo MKLLVMRT MKLLVMRT echo MKMANZ MKMANZ 
 echo MKNOUVEAUFIRMWARE MKNOUVEAUFIRMWARE echo MKNSD MKNSD echo MKOBJDIRS 
 MKOBJDIRS echo MKPCC MKPCC echo MKPICINSTALL MKPICINSTALL echo MKPIGZGZIP 
 MKPIGZGZIP echo MKRADEONFIRMWARE MKRADEONFIRMWARE echo MKREPRO MKREPRO 
 echo MKSLJIT MKSLJIT echo MKSOFTFLOAT MKSOFTFLOAT echo MKSTRIPIDENT 
 MKSTRIPIDENT echo MKTEGRAFIRMWARE MKTEGRAFIRMWARE echo MKTPM MKTPM echo 
 MKUNPRIVED MKUNPRIVED echo MKUPDATE MKUPDATE echo MKX11 MKX11 echo 
 MKX11MOTIF MKX11MOTIF echo MKXORG_SERVER MKXORG_SERVER echo MKZFS MKZFS 
 echo ARCH64 ARCH64 echo EABI EABI echo HAVE_ACPI HAVE_ACPI echo 
 HAVE_BINUTILS HAVE_BINUTILS echo HAVE_GCC HAVE_GCC echo HAVE_GDB HAVE_GDB 
 echo HAVE_LIBGCC_EH HAVE_LIBGCC_EH echo HAVE_MESA_VER HAVE_MESA_VER echo 
 HAVE_NVMM HAVE_NVMM echo HAVE_OPENSSL HAVE_OPENSSL echo HAVE_SSP HAVE_SSP 
 echo HAVE_UEFI HAVE_UEFI echo HAVE_XORG_GLAMOR HAVE_XORG_GLAMOR echo 
 HAVE_XORG_SERVER_VER HAVE_XORG_SERVER_VER echo KE
 ...
 
 and
 
 NetBSD:
 
 ...
 + echo 'USE_KERBEROS=yes'
 + echo 'USE_LDAP=yes'
 + echo 'USE_YP=yes'
 + echo COMPATARCHDIRS=sparc
 + echo KMODARCHDIRS=
 + echo MKSOLARIS=yes
 sets.subr contains:  echo MKARGON2 MKARGON2 echo MKATF MKATF echo 
 MKBINUTILS MKBINUTILS echo MKBSDTAR MKBSDTAR echo MKCLEANSRC MKCLEANSRC 
 echo MKCLEANVERIFY MKCLEANVERIFY echo MKCOMPLEX MKCOMPLEX echo MKCVS MKCVS 
 echo MKCXX MKCXX echo MKDOC MKDOC echo MKDTC MKDTC echo MKDYNAMICROOT 
 MKDYNAMICROOT echo MKGCC MKGCC echo MKGDB MKGDB echo MKGROFF MKGROFF echo 
 MKHESIOD MKHESIOD echo MKHTML MKHTML echo MKIEEEFP MKIEEEFP echo MKINET6 
 MKINET6 echo MKINFO MKINFO echo MKIPFILTER MKIPFILTER echo MKISCSI MKISCSI 
 echo MKKERBEROS MKKERBEROS echo MKKMOD MKKMOD echo MKLDAP MKLDAP echo 
 MKLIBSTDCXX MKLIBSTDCXX echo MKLINKLIB MKLINKLIB echo MKLVM MKLVM echo 
 MKMAKEMANDB MKMAKEMANDB echo MKMAN MKMAN echo MKMANDOC MKMANDOC echo 
 MKMDNS MKMDNS echo MKNLS MKNLS echo MKNPF MKNPF echo MKOBJ MKOBJ echo 
 MKPAM MKPAM echo MKPF MKPF echo MKPIC MKPIC echo MKPICLIB MKPICLIB echo 
 MKPOSTFIX MKPOSTFIX echo MKPROFILE MKPROFILE echo MKRUMP MKRUMP echo 
 MKSHARE MKSHARE echo MKSKEY MKSKEY echo MKSTATICLIB MKSTATICLIB echo 
 MKSTRIPSYM MKSTRIPSYM echo MKUNBOUND MKUNBOUND echo MKX11FONTS MKX11FONTS 
 echo MKYP MKYP echo MKGCCCMDS MKGCCCMDS echo MKAMDGPUFIRMWARE 
 MKAMDGPUFIRMWARE echo MKARZERO MKARZERO echo MKBSDGREP MKBSDGREP echo 
 MKCATPAGES MKCATPAGES echo MKCOMPATTESTS MKCOMPATTESTS echo MKCOMPATX11 
 MKCOMPATX11 echo MKCTF MKCTF echo MKDEBUG MKDEBUG echo MKDEBUGLIB 
 MKDEBUGLIB echo MKDEPINCLUDES MKDEPINCLUDES echo MKDTB MKDTB echo MKDTRACE 
 MKDTRACE echo MKFIRMWARE MKFIRMWARE echo MKGROFFHTMLDOC MKGROFFHTMLDOC 
 echo MKHOSTOBJ MKHOSTOBJ echo MKKYUA MKKYUA echo MKLIBCXX MKLIBCXX echo 
 MKLINT MKLINT echo MKLLVM MKLLVM echo MKLLVMRT MKLLVMRT e
 ...