Re: lib/57592: curses: aspell clears screen if no correction found

[Rin Okuyama <rokuyama.rk%gmail.com@localhost>]

The following reply was made to PR lib/57592; it has been noted by GNATS.

From: Rin Okuyama <rokuyama.rk%gmail.com@localhost>
To: RVP <rvp%SDF.ORG@localhost>, gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: lib/57592: curses: aspell clears screen if no correction found
Date: Sun, 10 Sep 2023 20:30:33 +0900

 On 2023/09/07 18:24, RVP wrote:
 > Can you show the output of these commands:
 > 
 > $ echo $TERM
 > $ ldd $(which aspell)
 > $ aspell -c foo.txt | sed -n l        # repeat for 9.0, 9.1, ncurses
 
 Thanks for useful comment!
 
 aspell linked against libcurses.so.9.1 outputs additional ``^[[H'' and
 ``^[[2J'' that cause screen clear.
 
 However, this is not a regression for our curses; aspell compiled for
 libcurses.so.9.0 and 9.1 are built with bunutils 2.34 and 2.39,
 respectively. And for the latter, a test in configure for aspell
 unexpectedly fails, which results in different behavior of aspell:
 
 ----
 configure:18529: checking if curses workaround I will work
 configure:18548: c++ -o conftest -O2 -fPIC -D_FORTIFY_SOURCE=2 -I/usr/include -fno-exceptions  -I/usr/include -I/usr/pkg/include -Wl,-zrelro -L/usr/lib -Wl,-R/usr/lib -Wl,-R/usr/pkg/lib conftest.cpp -lcurses  >&5
 ld: /tmp/cccBukDq.o: undefined reference to symbol 'tigetstr'
 ld: /usr/lib/libterminfo.so.2: error adding symbols: DSO missing from command line
 ----
 
 If ld 2.34 is used on a system itself built by 2.39, this test passes.
 
 As libncurses includes terminfo(3) functions, this test also passes
 for ncurses.
 
 This patch for pkgsrc/textproc/aspell works around the problem:
 https://gist.github.com/rokuyama/d5ad1e9f323e3773dae9c35e272f18a5
 
 Thanks,
 rin