kern/57617: ext2fs broken

[holovati%gmail.com@localhost]

>Number:         57617
>Category:       kern
>Synopsis:       ext2fs broken
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Sep 11 14:45:00 +0000 2023
>Originator:     Damir Holovati
>Release:        https://github.com/NetBSD/src
>Organization:
na
>Environment:
na
>Description:
Changes made in

/* $NetBSD: ext2fs_vfsops.c,v 1.225 2023/08/27 16:35:51 christos Exp $ */
break the loading of group descriptors.

ext2fs_vfsops.c:773  &m_fs->e2fs_gd[i * m_fs->e2fs_bsize/ sizeof(struct ext2_gd)]

is not the same as &m_fs->e2fs_gd[i * sh].

In the new code(e2fs_bsize = 0x400) e2fs_cgload writes 32 descriptors to e2fs_gd but "i * m_fs->e2fs_bsize/ sizeof(struct ext2_gd)" offsets e2fs_gd by 16.
>How-To-Repeat:
Try mounting a fs with 1024 byte blocks.
>Fix:
Revert to &m_fs->e2fs_gd[i * sh].