Re: lib/57631: pam_krb5.so seemingly randomly segfaults post the June update

[Taylor R Campbell <riastradh%NetBSD.org@localhost>]

The following reply was made to PR lib/57631; it has been noted by GNATS.

From: Taylor R Campbell <riastradh%NetBSD.org@localhost>
To: mark%ecs.vuw.ac.nz@localhost
Cc: gnats-bugs%NetBSD.org@localhost, netbsd-bugs%NetBSD.org@localhost
Subject: Re: lib/57631: pam_krb5.so seemingly randomly segfaults post the June update
Date: Wed, 27 Sep 2023 08:55:10 +0000

 This is a multi-part message in MIME format.
 --=_Jk88w0qeZbZBxabcXkD5GbHSqAbVNpLw
 
 Well, that's embarrassing.  Please try the attached patch?
 
 --=_Jk88w0qeZbZBxabcXkD5GbHSqAbVNpLw
 Content-Type: text/plain; charset="ISO-8859-1"; name="pam_krb5"
 Content-Transfer-Encoding: quoted-printable
 Content-Disposition: attachment; filename="pam_krb5.patch"
 
 diff --git a/lib/libpam/modules/pam_krb5/pam_krb5.c b/lib/libpam/modules/pa=
 m_krb5/pam_krb5.c
 index 38dd77472149..48941317285b 100644
 --- a/lib/libpam/modules/pam_krb5/pam_krb5.c
 +++ b/lib/libpam/modules/pam_krb5/pam_krb5.c
 @@ -955,6 +955,7 @@ verify_krb_v5_tgt_begin(krb5_context context, char *pam=
 _service, int debug,
  	const char *services[3], **service;
 =20
  	*servicep =3D NULL;
 +	*princp =3D NULL;
 =20
  	if (debug)
  		openlog_r("pam_krb5", LOG_PID, LOG_AUTHPRIV, datap);
 @@ -996,6 +997,8 @@ verify_krb_v5_tgt_begin(krb5_context context, char *pam=
 _service, int debug,
  		    &keyblock);
  		if (retval !=3D 0)
  			continue;
 +		*servicep =3D *service;
 +		*princp =3D princ;
  		break;
  	}
  	if (keyblock)
 
 --=_Jk88w0qeZbZBxabcXkD5GbHSqAbVNpLw--