Re: kern/57648: ure(4) ignores multicasts in promisc mode

[sc.dying%gmail.com@localhost]

The following reply was made to PR kern/57648; it has been noted by GNATS.

From: sc.dying%gmail.com@localhost
To: gnats-bugs%netbsd.org@localhost, kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost
Cc: 
Subject: Re: kern/57648: ure(4) ignores multicasts in promisc mode
Date: Mon, 9 Oct 2023 07:43:05 +0000

 On 2023/10/09 6:10, Martin Husemann wrote:
 > The following reply was made to PR kern/57648; it has been noted by GNATS.
 > 
 > From: Martin Husemann <martin%duskware.de@localhost>
 > To: gnats-bugs%netbsd.org@localhost
 > Cc: 
 > Subject: Re: kern/57648: ure(4) ignores multicasts in promisc mode
 > Date: Mon, 9 Oct 2023 08:07:16 +0200
 > 
 >  On Sun, Oct 08, 2023 at 08:35:01PM +0000, sc.dying%gmail.com@localhost wrote:
 >  > >How-To-Repeat:
 >  > 	code comparison with netbsd-9
 >  
 >  Have you tested it?
 
 Yes, patched code builds and works.
 
 ping6 to a address that is not any of ure under test
 generates ND multicast packet.
 If usbnet promisc bug is fixed, you can confirm that
 ure in promisc mode cannot observe this multicast
 on tcpdump.
 
 >  
 >  > Please apply this patch.
 >  > 
 >  > --- sys/dev/usb/if_ure.c.orig	2022-09-16 22:11:45.019756111 +0000
 >  > +++ sys/dev/usb/if_ure.c	2023-10-08 19:35:26.905586897 +0000
 >  > @@ -358,6 +358,7 @@ ure_uno_mcast(struct ifnet *ifp)
 >  >  		/* run promisc. mode */
 >  >  		rxmode |= URE_RCR_AM;	/* ??? */
 >  >  		rxmode |= URE_RCR_AAP;
 >  > +		mchash[0] = mchash[1] = ~0U;
 >  
 >  Shouldn't this be a no-op due to URE_RCR_AM being set?
 
 I'm not sure this is a bug.
 netbsd-9's if_ure.c line 366 and
 linux's drivers/net/usb/r8152.c line 2736
 describe so.
 
 >  
 >  Martin
 >