Re: kern/58235: compat_netbsd32 broken for SIOCGIFDATA

[Paul Goyette <paul%whooppee.com@localhost>]

The following reply was made to PR kern/58235; it has been noted by GNATS.

From: Paul Goyette <paul%whooppee.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/58235: compat_netbsd32 broken for SIOCGIFDATA
Date: Thu, 9 May 2024 00:06:08 -0700 (PDT)

 On Thu, 9 May 2024, Martin Husemann wrote:
 
 > The following reply was made to PR kern/58235; it has been noted by GNATS.
 >
 > From: Martin Husemann <martin%duskware.de@localhost>
 > To: gnats-bugs%netbsd.org@localhost
 > Cc:
 > Subject: Re: kern/58235: compat_netbsd32 broken for SIOCGIFDATA
 > Date: Thu, 9 May 2024 08:37:20 +0200
 >
 > On Wed, May 08, 2024 at 10:35:01PM +0000, Paul Goyette wrote:
 > >  > This additionall change should probsbly go into some source file
 > >  > like compat32_netif_50.c and be added to the compat_netbsd32_50
 > >  > module.  This would give us compat32 support for pre- and post-50
 > >
 > >  A good example of where this has prevously been done might be the
 > >  src/sys/modules/compat_netbsd32_quota{,_50} modules.
 >
 > Sorry, you lost me here - what additional change?
 
 Sorry, my poor phrasing - I got lost, too!
 
 The timespec change varies depending on whether you have compat_50 or
 not.  So to be fully compatable, there needs to be two versions of the
 compat32 stuff, not just one.  Both versions need to adjust for the
 other args.
 
 For completeness, you should test your changes for two different
 i386 images.  Both images would be 32-bit, but one image would be
 from pre-5.0 and the other image would be post-5.0 (or current).
 
 There would be _two_ modules affected by the changes.  The "plain"
 compat_netbsd32, and the compat_netbsd32_50 module.
 
 +---------------------+--------------------------+----------------------+
 | Paul Goyette (.sig) | PGP Key fingerprint:     | E-mail addresses:    |
 | (Retired)           | 1B11 1849 721C 56C8 F63A | paul%whooppee.com@localhost    |
 | Software Developer  | 6E2E 05FD 15CE 9F2D 5102 | pgoyette%netbsd.org@localhost  |
 | & Network Engineer  |                          | pgoyette99%gmail.com@localhost |
 +---------------------+--------------------------+----------------------+