Re: bin/58467: ctwm does not move the application window to the specified workspace

[RVP <rvp%SDF.ORG@localhost>]

The following reply was made to PR bin/58467; it has been noted by GNATS.

From: RVP <rvp%SDF.ORG@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: bin/58467: ctwm does not move the application window to the
 specified workspace
Date: Sat, 27 Jul 2024 07:41:07 +0000 (UTC)

 On Fri, 26 Jul 2024, szymon wrote:
 
 > Ctwm 4.0.3 is installed with NetBSD 10.0 operating system.
 > Unfortunately I have no possibility to test your patch.
 >
 
 No prob. I think I've got the proximate cause of this issue. Try
 this modified ~/.ctwmrc:
 
 ```
 --- /etc/X11/ctwm/system.ctwmrc	2024-05-31 13:11:41.000000000 +0000
 +++ .ctwmrc	2024-07-27 07:10:46.685887738 +0000
 @@ -183,8 +183,8 @@
   NoShowOccupyAll
   ReverseCurrentWorkspace
   StartInMapState
 -WMgrHorizButtonIndent     0
 -WMgrVertButtonIndent      0
 +WMgrHorizButtonIndent     1
 +WMgrVertButtonIndent      1
 
   WorkSpaces
   {
 ```
 
 Ie. set those variables to 1 instead of 0. A value of 0 doesn't
 seem to be handled correctly by the code.
 
 You can also upstream this patch for review--it does the same thing:
 
 ```
 diff -urN a/xsrc/external/mit/ctwm/dist/parse_be.c b/xsrc/external/mit/ctwm/dist/parse_be.c
 --- a/xsrc/external/mit/ctwm/dist/parse_be.c	2023-07-05 07:36:06.000000000 +0000
 +++ b/xsrc/external/mit/ctwm/dist/parse_be.c	2024-07-27 07:19:21.895964575 +0000
 @@ -1280,8 +1280,8 @@
   			if(Scr->FirstTime) {
   				Scr->WMgrVertButtonIndent = num;
   			}
 -			if(Scr->WMgrVertButtonIndent < 0) {
 -				Scr->WMgrVertButtonIndent = 0;
 +			if(Scr->WMgrVertButtonIndent < 1) {
 +				Scr->WMgrVertButtonIndent = 1;
   			}
   			Scr->workSpaceMgr.vspace = Scr->WMgrVertButtonIndent;
   			Scr->workSpaceMgr.occupyWindow->vspace = Scr->WMgrVertButtonIndent;
 @@ -1291,8 +1291,8 @@
   			if(Scr->FirstTime) {
   				Scr->WMgrHorizButtonIndent = num;
   			}
 -			if(Scr->WMgrHorizButtonIndent < 0) {
 -				Scr->WMgrHorizButtonIndent = 0;
 +			if(Scr->WMgrHorizButtonIndent < 1) {
 +				Scr->WMgrHorizButtonIndent = 1;
   			}
   			Scr->workSpaceMgr.hspace = Scr->WMgrHorizButtonIndent;
   			Scr->workSpaceMgr.occupyWindow->hspace = Scr->WMgrHorizButtonIndent;
 ```
 
 Should be easy to apply by hand to both pkgsrc and the system ctwm-4.1.0.
 
 > Regarding the second part of the answer, I don't quite understand. I
 > didn't ask about switching workspaces after moving the window.
 >
 
 I know--it was a bonus.
 
 -RVP