PR/56252 CVS commit: src/sys/net

["Taylor R Campbell" <riastradh%netbsd.org@localhost>]

The following reply was made to PR kern/56252; it has been noted by GNATS.

From: "Taylor R Campbell" <riastradh%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/56252 CVS commit: src/sys/net
Date: Mon, 29 Jul 2024 16:01:13 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Mon Jul 29 16:01:13 UTC 2024
 
 Modified Files:
 	src/sys/net: if_wg.c
 
 Log Message:
 wg(4): Omit needless atomic_load.
 
 wgs_local_index is only ever written to while only one thread has
 access to it and it is not in the thmap -- before it is published in
 wg_get_session_index, and after it is unpublished in
 wg_destroy_session.  So no need for atomic_load -- it is stable if we
 observe it in thmap_get result.
 
 (Of course this is only for an assertion, which if tripped obviously
 indicates a violation of our assumptions.  But if that happens, well,
 in the worst case we'll see a weird assertion message claiming that
 the index is not equal to itself, which from which we can conclude
 there must have been a concurrent update, which is good enough to
 help diagnose that problem without any atomic_load.)
 
 Tidying some of the changes for:
 
 PR kern/55729: net/if_wg/t_misc:wg_rekey test case fails
 PR kern/56252: wg(4) state machine has race conditions
 PR kern/58463: if_wg does not work when idle.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.119 -r1.120 src/sys/net/if_wg.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.