kern/58530: panic: kernel diagnostic assertion "!netq->netq_stopping" failed: file "/syzkaller/managers/ci2-netbsd/kernel/sys/dev/pci/if_vioif.c", line 1891

[campbell+netbsd%mumble.net@localhost]

>Number:         58530
>Category:       kern
>Synopsis:       panic: kernel diagnostic assertion "!netq->netq_stopping" failed: file "/syzkaller/managers/ci2-netbsd/kernel/sys/dev/pci/if_vioif.c", line 1891
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jul 31 10:25:00 +0000 2024
>Originator:     Taylor R Campbell
>Release:        current, 10
>Organization:
The NetStopping Voundation
>Environment:
>Description:
panic: kernel diagnostic assertion "!netq->netq_stopping" failed: file "/syzkaller/managers/ci2-netbsd/kernel/sys/dev/pci/if_vioif.c", line 1891
[ 563.2848158] cpu0: Begin traceback...
[ 563.2848158] vpanic() at netbsd:vpanic+0x282 sys/kern/subr_prf.c:292
[ 563.2848158] _sub_D_65535_0() at netbsd:_sub_D_65535_0+-0x23509
[ 563.2848158] vioif_rx_handle_locked() at netbsd:vioif_rx_handle_locked+0x27c sys/dev/pci/if_vioif.c:1891
[ 563.2848158] vioif_rx_intr() at netbsd:vioif_rx_intr+0xa2 sys/dev/pci/if_vioif.c:1934
[ 563.2848158] virtio_vq_intr() at netbsd:virtio_vq_intr+0xbe sys/dev/pci/virtio.c:462
[ 563.2848158] virtio_pci_msix_queue_intr() at netbsd:virtio_pci_msix_queue_intr+0x78 sys/dev/pci/virtio_pci.c:1225
[ 563.2848158] intr_biglock_wrapper() at netbsd:intr_biglock_wrapper+0x85 sys/arch/x86/x86/intr.c:678
[ 563.2848158] Xhandle_ioapic_edge19() at netbsd:Xhandle_ioapic_edge19+0x75
[ 563.2848158] --- interrupt ---
[ 563.2848158] _kernel_lock() at netbsd:_kernel_lock+0x495 sys/kern/kern_lock.c:266
[ 563.2848158] tcp_send_wrapper() at netbsd:tcp_send_wrapper+0x29 tcp_send sys/netinet/tcp_usrreq.c:1008 [inline]
[ 563.2848158] tcp_send_wrapper() at netbsd:tcp_send_wrapper+0x29 sys/netinet/tcp_usrreq.c:2333
[ 563.2848158] sosend() at netbsd:sosend+0x12f5 sys/kern/uipc_socket.c:1069
[ 563.2848158] soo_write() at netbsd:soo_write+0x5c sys/kern/sys_socket.c:127
[ 563.2848158] dofilewrite() at netbsd:dofilewrite+0x1cf sys/kern/sys_generic.c:352
[ 563.2848158] sys_write() at netbsd:sys_write+0x9c sys/kern/sys_generic.c:320
[ 563.2848158] syscall() at netbsd:syscall+0x25a sy_call sys/sys/syscallvar.h:65 [inline]
[ 563.2848158] syscall() at netbsd:syscall+0x25a sy_invoke sys/sys/syscallvar.h:94 [inline]
[ 563.2848158] syscall() at netbsd:syscall+0x25a sys/arch/x86/x86/syscall.c:138
[ 563.2848158] --- syscall (number 4) ---
>How-To-Repeat:
ifconfig vioif0 down during heavy traffic, probably -- no reproducer from syzkaller
>Fix:
https://mail-index.netbsd.org/source-changes/2023/05/11/msg144577.html
committed on HEAD, needs pullup-10