misc/58568: t_tcpdump leaves garbage in /tmp

[campbell+netbsd%mumble.net@localhost]

>Number:         58568
>Category:       misc
>Synopsis:       t_tcpdump leaves garbage in /tmp
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    misc-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Aug 10 13:20:02 +0000 2024
>Originator:     Taylor R Campbell
>Release:        current, 10, 9, ...
>Organization:
The /tmp/NetBSD.3EZCqp Foundacheck
>Environment:
>Description:
Running /usr/tests/usr.sbin/tcpdump/t_tcpdump leaves a temporary directory in /tmp/check.XXXXXX, where XXXXXX is randomly generated each time, having two regular files called `stderr' and `stdout'.

This is probably because the test starts an atf-check(1) process running tcpdump in the background, and then kills that process.  I have no idea what this is supposed to achieve (surely if you kill the atf-check(1) process, it doesn't actually check anything?), but I suspect that killing the atf-check(1) process makes it skip the tempfile cleanup.
>How-To-Repeat:
cd /usr/tests/usr.sbin/tcpdump && atf-run t_tcpdump | atf-report
>Fix:
Yes, please!

Maybe just skip the intermediate atf-check and run tcpdump directly?