Re: kern/58582: [PATCH] Do not rely on outside inclusion in rasops.h and wsdisplay_vconsvar.h

[gnats-admin%netbsd.org@localhost]

The following reply was made to PR kern/58582; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/58582: [PATCH] Do not rely on outside inclusion in rasops.h
 and wsdisplay_vconsvar.h
Date: Sun, 11 Aug 2024 17:13:16 +0200

 On Sun, Aug 11, 2024 at 02:20:00PM +0000, gorg%gorgnet.net@localhost wrote:
 > In their current forms, rasops.h and wsdisplay_vconsvar.h require the inclusion
 > of either wsdisplayvar.h or wsdisplayvar.h and rasops.h, respectively, by the
 > source file that includes them. This is because they use symbols from these
 > other header files without including such header files themselves, contrary to
 > the NetBSD source code style guide:
 
 IIRC conceptually rasops should be independent of wsdisplay (and used
 to be in the past), what symbols from there is it using?
 
 Martin